Bug 18343 - Improper close during KDrive :: LinuxInit
Summary: Improper close during KDrive :: LinuxInit
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: All Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-01 13:26 UTC by Jim Huang
Modified: 2009-02-01 09:26 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
Fixlet to LinuxInit (443 bytes, patch)
2008-11-01 13:26 UTC, Jim Huang 		no flags Details | Splinter Review
View All

Description Jim Huang 2008-11-01 13:26:15 UTC 
Created attachment 19995 [details] [review]
Fixlet to LinuxInit

In hw/kdrive/linux/linux.c (LinuxInit), there is a routine attempting to open /dev/tty0.  However, the corresponding close() was misplaced, which led to redundant operations when most normal case.
Comment 1 Eric Anholt 2009-02-01 09:26:17 UTC 
commit 66a6fbbfa3a1fd0d91fe61cf2ab299d0e3df46b9
Author: Jim Huang <jserv@kaffe.org>
Date:   Sun Feb 1 09:19:20 2009 -0800

    kdrive: Move a close() to the right place so we don't close(-1) normally.
    
    Bug #18343

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.