Bug 18461 - pm/sleep.d/98smart-kernel-video misfires on IBM X40
Summary: pm/sleep.d/98smart-kernel-video misfires on IBM X40
Status: RESOLVED NOTOURBUG
Alias: None
Product: pm-utils
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Victor Lowther
QA Contact:
URL: http://bugs.launchpad.net/bugs/292256
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-09 20:57 UTC by Chow Loong Jin
Modified: 2009-12-10 20:26 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Chow Loong Jin 2008-11-09 20:57:46 UTC
On IBM X40, --quirk-vbe-post is required in order to turn the back-light on after resuming from suspend. However, the hook detects an Intel card, and removes this quirk, even though HAL is passing it into pm-utils. As a result, IBM X40 systems have the back-light turned off upon suspend. Removing the hook seems to fix the issue on the affected systems.

The version of pm-utils is 1.1.2.4-1ubuntu8 on Ubuntu Intrepid Ibex, and the kernel is 2.6.27.
Comment 1 Yves-Alexis 2009-07-15 05:03:05 UTC
Not sure if that's the same bug or another one, but yes, 98smart-kernel-video wrongly detects KMS:

http://cgit.freedesktop.org/pm-utils/tree/pm/sleep.d/98smart-kernel-video#n31

uses /sys/class/drm/card0/device/graphics/fb0 which is present on my x31 with radeon card and radeonfb (and no KMS at all, I'm on 2.6.30).

I'm not sure there's an easy way to detect a running KMS kernel. Checking /sys/module/i915/parameters/modeset might help, but only on intel systems with i915 as a module.

Cheers,
Comment 2 Victor Lowther 2009-12-06 11:20:21 UTC
Kernel modesetting support in the latest pm-utils releases should no longer have this bug -- please try testing with pm-utils 1.2.6.1
Comment 3 Chow Loong Jin 2009-12-06 16:31:35 UTC
(In reply to comment #2)
> Kernel modesetting support in the latest pm-utils releases should no longer
> have this bug -- please try testing with pm-utils 1.2.6.1
> 
Actually it seems from recent comments in the original bug at Launchpad.net that having KMS on removes some needed quirks for the X40.

On the other hand, it seems there's a kernel bug in which a patch is attached at http://bugzilla.kernel.org/show_bug.cgi?id=10985 which presumably removes the need for those quirks.

Until that patch is committed to the kernel, perhaps more checks are needed to avoid removing certain quirks under certain circumstances?
Comment 4 Victor Lowther 2009-12-10 20:26:46 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Kernel modesetting support in the latest pm-utils releases should no longer
> > have this bug -- please try testing with pm-utils 1.2.6.1
> > 
> Actually it seems from recent comments in the original bug at Launchpad.net
> that having KMS on removes some needed quirks for the X40.
> 
> On the other hand, it seems there's a kernel bug in which a patch is attached
> at http://bugzilla.kernel.org/show_bug.cgi?id=10985 which presumably removes
> the need for those quirks.
> 
> Until that patch is committed to the kernel, perhaps more checks are needed to
> avoid removing certain quirks under certain circumstances?

Not when using KMS, no -- one of the primary goals of kernel modesetting is to eliminate quirks -- I am amenable to making it easier to let users temporarily work around any KMS related bugs using quirks, but I will not import KMS related quirks into pm-utils.
 


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.