Building ConsoleKit-0.3.0 on OS X 10.4, whose x11 calls itself "X11 1.1.3 - XFree86 4.4.0" (I think that first part is apple's package installer-bundle versioning?):
>checking for TOOLS... configure: error: Package requirements (x11 >= 1.0.0
> glib-2.0 >= 2.7.0
>) were not met:
>No package 'x11' found
>Consider adjusting the PKG_CONFIG_PATH environment variable if you
>installed software in a non-standard prefix.
>Alternatively, you may set the environment variables TOOLS_CFLAGS
>and TOOLS_LIBS to avoid the need to call pkg-config.
>See the pkg-config man page for more details.
Apparently x11.pc was a (relatively) recent addition to x11. Other packages have a fallback to using vairous autoconf tests for x11 if pkg-config fails to find it. I could use (as it says) the TOOLS_* vars, but then I'd have to know the glib-2.0 flags myself (which are often complicated) rather than just some standard /usr/X11 paths and -lX11. At a minimum, would be great if x11 were unbundled from the glib-2.0 test, so that I could manually pass my x11 flags (X11_* or so) to override x11.pc, and then pkg-config's glib-2.0.pc would be prepended to accomplish the full TOOLS_* set. Probably more work and less standard than just using ac's own tests though.
Created attachment 20754 [details] [review]
Fall back to autoconf standard for x11 detection
Maybe not pretty, but Works For Me(tm).
Finds x11 on my machine with no x11.pc and winds up with Makefile variables:
TOOLS_CFLAGS = -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/usr/X11R6/include
TOOLS_LIBS = -L/sw/lib -lglib-2.0 -lintl -L/usr/X11R6/lib -lX11
which looks correct, and the various x11-related source files (tools/ck-get-x11-display-device.c and tools/ck-get-x11-server-pid.c) compile with no warnings, and linking doesn't fail due to unresolved XOpenDisplay symbol.
Is this something you still need Daniel?
Sorry, didn't notice the followup. But to answer, "no". OS X's standard x11--via XQuartz--has had x11.pc for at least the past several years and on several of the most recent major OS X releases. Feel free to close.