Bug 1886 - r128 dri does not release interrupts after exiting
Summary: r128 dri does not release interrupts after exiting
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/rage128 (show other bugs)
Version: git
Hardware: All Linux (All)
: high major
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-22 08:35 UTC by Daniel Stone
Modified: 2004-12-14 05:54 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[FIXED_X11R68x] trivial patch (507 bytes, patch)
2004-11-22 08:36 UTC, Daniel Stone
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Daniel Stone 2004-11-22 08:35:36 UTC
Summary essentially says it all -- r128_dri.c sets save->gen_int_cntl when it
registers a DRM handler, and fails to unset it when it releases it, which can
cause lockups later on.  Trivial patch attached.

Ubuntu 025_r128_remove_interrupt_handler.diff, present in 6.8.1-1ubuntu4 and later.
Comment 1 Daniel Stone 2004-11-22 08:36:16 UTC
Created attachment 1327 [details] [review]
[FIXED_X11R68x] trivial patch
Comment 2 Daniel Stone 2004-11-23 11:02:33 UTC
Comment on attachment 1327 [details] [review]
[FIXED_X11R68x] trivial patch

make roland less angry
Comment 3 Daniel Stone 2004-11-23 14:02:07 UTC
This has been observed in Red Hat also
(https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138822) and shown to be
correct; I would like to commit it as it also seems quite obviously correct to me.
Comment 4 Daniel Stone 2004-12-04 14:28:16 UTC
Comment on attachment 1327 [details] [review]
[FIXED_X11R68x] trivial patch

fixed in HEAD, please consider for 6.8.2
Comment 5 Roland Mainz 2004-12-11 15:27:53 UTC
Comment on attachment 1327 [details] [review]
[FIXED_X11R68x] trivial patch

Approval for X11R6.8.x stable branch granted in the 2004-12-08
release-wranglers phone call.
Please don't commit, I'll do that myself...
Comment 6 Roland Mainz 2004-12-15 00:53:23 UTC
Comment on attachment 1327 [details] [review]
[FIXED_X11R68x] trivial patch

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.87; previous revision: 1.365.2.86
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/ati/r128_dri.c,v  <-- 
r128_dri.c
new revision: 1.4.4.1; previous revision: 1.4
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 7 Roland Mainz 2004-12-15 00:54:30 UTC
Patch checked-in into Xorg trunk and X11R6.8.x stable branch...

... marking bug as FIXED (please reopen if there are any outstanding issues).


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.