Bug 18860 - Clearer diagnostic if platform back-end isn't implemented
Summary: Clearer diagnostic if platform back-end isn't implemented
Status: RESOLVED FIXED
Alias: None
Product: ConsoleKit
Classification: Unclassified
Component: libck-connector (show other bugs)
Version: unspecified
Hardware: PowerPC Mac OS X (All)
: medium normal
Assignee: william.jon.mccann
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-02 22:59 UTC by Daniel Macks
Modified: 2009-02-11 18:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Error if no backend for target host (416 bytes, patch)
2008-12-02 23:00 UTC, Daniel Macks
Details | Splinter Review

Description Daniel Macks 2008-12-02 22:59:36 UTC
Trying to build ConsoleKit-0.3.0 on OS X 10.4 (darwin8.11.0), I can ./configure && make, and nothing looks bad until:

>gcc -g -O2 -o test-vt-monitor ck-vt-monitor.o test-vt-monitor.o  -L/sw/lib /sw/lib/libdbus-glib-1.dylib /sw/lib/libdbus-1.dylib /sw/lib/libgobject-2.0.dylib /sw/lib/libgthread-2.0.dylib /sw/lib/libglib-2.0.dylib /sw/lib/libintl.dylib /sw/lib/libiconv.dylib -lc ./.libs/libck.a  
>/usr/libexec/gcc/powerpc-apple-darwin8/4.0.1/ld: Undefined symbols:
>_ck_get_active_console_num
>_ck_get_max_num_consoles
>collect2: ld returned 1 exit status

./configure only checks for which of the *supported* backends to use (freebsd, linux, solaris). If "none of the above", no back-end source is added to src/Makefile.am libck_la_SOURCES, so of course those symbols aren't implemented anywhere. But that's only obvious because I looked at the sources and Makefile.am and configure.ac. Would be saner if ./configure gave a clear message ASAP if there's no backend implemented for the target platform until waiting for a cryptic compiler failure.
Comment 1 Daniel Macks 2008-12-02 23:00:07 UTC
Created attachment 20755 [details] [review]
Error if no backend for target host
Comment 2 william.jon.mccann 2009-02-11 18:58:04 UTC
Sorry for the delay and thanks for the patch.  I've committed this to master now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.