Bug 1890 - doesn't resume as well as it should
Summary: doesn't resume as well as it should
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) All
: high normal
Assignee: Xorg Project Team
QA Contact:
URL: http://bugs.debian.org/234575
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-22 10:06 UTC by Daniel Stone
Modified: 2004-12-15 21:16 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
[FIXED_X11R68x] post me harder (1.58 KB, patch)
2004-11-22 10:11 UTC, Daniel Stone
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Daniel Stone 2004-11-22 10:06:51 UTC
On some chips, when we come back from a resume, the card is still stuck in
ACPI's D3cold (basically, zero power), and it comes back up in an incomplete
state; the most obvious symptom of this is thinking it has a memory size of
zero.  The attached patch (Debian/Ubuntu #079, has been present for a while)
re-POSTs the card, which allows S3 suspend/resume for a lot of Dell laptops and
has caused no known problems elsewhere.
Comment 1 Daniel Stone 2004-11-22 10:11:27 UTC
Created attachment 1331 [details] [review]
[FIXED_X11R68x] post me harder
Comment 2 Donnie Berkholz 2004-11-22 11:28:24 UTC
Gentoo's had this as well since July, if you want more testing.
Comment 3 Daniel Stone 2004-11-23 11:01:42 UTC
Comment on attachment 1331 [details] [review]
[FIXED_X11R68x] post me harder

make roland less angry
Comment 4 Daniel Stone 2004-12-06 05:23:09 UTC
Comment on attachment 1331 [details] [review]
[FIXED_X11R68x] post me harder

committed to HEAD, please consider for 6.8.2
Comment 5 Roland Mainz 2004-12-11 15:29:29 UTC
Comment on attachment 1331 [details] [review]
[FIXED_X11R68x] post me harder

Approval for X11R6.8.x stable branch granted in the 2004-12-08
release-wranglers phone call.
Please don't commit, I'll do that myself...
Comment 6 Roland Mainz 2004-12-16 15:55:23 UTC
Comment on attachment 1331 [details] [review]
[FIXED_X11R68x] post me harder

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.100; previous revision: 1.365.2.99
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/drivers/ati/radeon_driver.c,v	<-- 
radeon_driver.c
new revision: 1.19.2.6; previous revision: 1.19.2.5
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 7 Roland Mainz 2004-12-16 15:56:16 UTC
Patch checked-in into X11R6.8.x stable branch and Xorg trunk...

... marking bug as FIXED.
Comment 8 Carl-Daniel Hailfinger 2004-12-16 16:16:01 UTC
Thank you very much, Roland!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.