The attached (rather large, I'm afraid) patch adds proper pt_BR support to libX11, instead of making it a simple en_US.UTF-8 derivative.
Created attachment 1337 [details] [review] large patch
Uhm... daniel... are you aware that patches which should go into the X11R6.8.x branch have to be 1. Reviewed 2. Commited to the Xorg CVS trunk and then, finally 3. Requested approval for X11R6.8.x ?
Comment on attachment 1337 [details] [review] large patch Uhm... this part cannot be correct: -- snip -- +XLC_FONTSET + +on_demand_loading True + +object_name generic + +# fs0 class +fs0 { + charset { + name ISO10646-1 + } + font { + primary ISO10646-1 + } -- snip -- This is basically the same issue as in bug 1842 ("Move iso10646 fontset down in fallback chain").
Comment on attachment 1337 [details] [review] large patch BTW: The patch misses an entry for pt_BR* in xc/programs/Xserver/XpConfig/Imakefile ;-(
ISO10646-1> yeah, I'll take a look at that -- thanks, good catch! Xprint> Debian is back on 4.3, and thus ships the Xprint from xprint.org, but no-one pays much attention at all to that package; Ubuntu ships Xprint from X.Org only because we haven't managed to fully depreciate it, but it is not treated equally. accordingly, you should watch for these kinds of desyncs in all our patches if you want to make sure you keep Xprint in sync.
Created attachment 1359 [details] [review] updated patch try this new patch, which has the font ordering fixed
Comment on attachment 1359 [details] [review] updated patch Should be right -- untested, just waiting for another build to spin around.
Comment on attachment 1359 [details] [review] updated patch ienup: can you take a look at the patch and check whether it is OK (except the still missing entries in xc/programs/Xserver/XpConfig/Imakefile) ?
Comment on attachment 1359 [details] [review] updated patch make roland less angry
(In reply to comment #5) > ISO10646-1> yeah, I'll take a look at that -- thanks, good catch! > Xprint> Debian is back on 4.3, and thus ships the Xprint from xprint.org, but > no-one pays much attention at all to that package; Really? Just because noone complains it doesn't mean that the package is not being used. A couple of people pay lots of attention of what is happening here with Xprint. As the Xprint and X.org CVS are now the same and Xprint is again part of the X.org distribution you should simply do what everyone else did: Honor the review comment and provide the neccesary patch. Thanks! > Ubuntu ships Xprint from > X.Org only because we haven't managed to fully depreciate it, Who wants the Xprint support to be depreciated?
> Really? Just because noone complains it doesn't mean that the package is not > being used. A couple of people pay lots of attention of what is happening here > with Xprint. As the Xprint and X.org CVS are now the same and Xprint is again > part of the X.org distribution you should simply do what everyone else did: > Honor the review comment and provide the neccesary patch. Thanks! Yes, I'm working on it, but have been dragged away to other things today, unfortunately. Of course, since I do not work on Xprint, I would appreciate it if more experienced eyes got to it before I did. > Who wants the Xprint support to be depreciated? There was a decision made to settle on CUPS as our single, unified, printing system. We were not interested in having multiple printing systems around, and it was a decision I am unconcerned about. This argument is offtopic for this forum, though.
(In reply to comment #11) > > Really? Just because noone complains it doesn't mean that the package is not > > being used. A couple of people pay lots of attention of what is happening here > > with Xprint. As the Xprint and X.org CVS are now the same and Xprint is again > > part of the X.org distribution you should simply do what everyone else did: > > Honor the review comment and provide the neccesary patch. Thanks! > > Yes, I'm working on it, but have been dragged away to other things today, > unfortunately. Of course, since I do not work on Xprint, I would appreciate it AFAIK the information in the makefile just sets an alias here, either for counties which honor the ISO or have their own standards (like USA); either Roland or Jay Hobson/Sun may have further information. > if more experienced eyes got to it before I did. > > > Who wants the Xprint support to be depreciated? > > There was a decision made to settle on CUPS as our single, unified, printing > system. We were not interested in having multiple printing systems around, and > it was a decision I am unconcerned about. This argument is offtopic for this > forum, though. Xprint is a layer on top of CUPS, it does not replace it nor are there any plans to do so. You are mixing spooler with application layer print api here. Noone is talking about replacing CUPS at all.
Created attachment 1675 [details] [review] Updated patch for 2005-01-14-trunk
Comment on attachment 1675 [details] [review] Updated patch for 2005-01-14-trunk ienup: Can you take a look at the new patch, please ?
I just reviewed the new patch and it looked good to me.
Created attachment 1711 [details] [review] [FIXED_X11R68x] Patch for commit against Xorg 2005-01-18-trunk CVS (same as attachment #1675 [details] [review], I just added a Changelog entry) ---- Taking bug myself for commit...
Patch checked-in... /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.691; previous revision: 1.690 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/nls/compose.dir,v <-- compose.dir new revision: 1.8; previous revision: 1.7 /cvs/xorg/xc/nls/locale.dir,v <-- locale.dir new revision: 1.7; previous revision: 1.6 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/nls/Compose/Imakefile,v <-- Imakefile new revision: 1.4; previous revision: 1.3 /cvs/xorg/xc/nls/Compose/pt_BR.UTF-8,v <-- pt_BR.UTF-8 initial revision: 1.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/nls/XI18N_OBJS/Imakefile,v <-- Imakefile new revision: 1.4; previous revision: 1.3 /cvs/xorg/xc/nls/XI18N_OBJS/pt_BR.UTF-8,v <-- pt_BR.UTF-8 initial revision: 1.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/nls/XLC_LOCALE/Imakefile,v <-- Imakefile new revision: 1.4; previous revision: 1.3 /cvs/xorg/xc/nls/XLC_LOCALE/pt_BR.UTF-8,v <-- pt_BR.UTF-8 initial revision: 1.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/XpConfig/Imakefile,v <-- Imakefile new revision: 1.6; previous revision: 1.5 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... ... marking bug as FIXED.
Comment on attachment 1711 [details] [review] [FIXED_X11R68x] Patch for commit against Xorg 2005-01-18-trunk CVS nominating for 6.8.x again
Comment on attachment 1711 [details] [review] [FIXED_X11R68x] Patch for commit against Xorg 2005-01-18-trunk CVS Approval for commit into X11R6.8.x stable branch granted in the 2005-01-24 release-wranglers phone call (please don't commit, I'll do that myself in a few mins).
Comment on attachment 1711 [details] [review] [FIXED_X11R68x] Patch for commit against Xorg 2005-01-18-trunk CVS Patch checked-in into X11R6.8.x stable branch: /cvs/xorg/xc/ChangeLog,v <-- ChangeLog new revision: 1.365.2.135; previous revision: 1.365.2.134 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/nls/compose.dir,v <-- compose.dir new revision: 1.2.4.1; previous revision: 1.2 /cvs/xorg/xc/nls/locale.dir,v <-- locale.dir new revision: 1.2.4.1; previous revision: 1.2 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/nls/Compose/Imakefile,v <-- Imakefile new revision: 1.2.4.1; previous revision: 1.2 /cvs/xorg/xc/nls/Compose/pt_BR.UTF-8,v <-- pt_BR.UTF-8 new revision: 1.1.2.1; previous revision: 1.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/nls/XI18N_OBJS/Imakefile,v <-- Imakefile new revision: 1.2.4.1; previous revision: 1.2 /cvs/xorg/xc/nls/XI18N_OBJS/pt_BR.UTF-8,v <-- pt_BR.UTF-8 new revision: 1.1.2.1; previous revision: 1.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/nls/XLC_LOCALE/Imakefile,v <-- Imakefile new revision: 1.2.4.1; previous revision: 1.2 /cvs/xorg/xc/nls/XLC_LOCALE/pt_BR.UTF-8,v <-- pt_BR.UTF-8 new revision: 1.1.2.1; previous revision: 1.1 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/XpConfig/Imakefile,v <-- Imakefile new revision: 1.2.6.1; previous revision: 1.2 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org...
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.