Bug 18987 - Memory leaks in gc-web-service.c
Summary: Memory leaks in gc-web-service.c
Status: RESOLVED FIXED
Alias: None
Product: GeoClue
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: highest major
Assignee: Geoclue Bugs
QA Contact: Geoclue Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-09 13:03 UTC by Csaba Kertész
Modified: 2008-12-10 12:20 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Csaba Kertész 2008-12-09 13:03:37 UTC 
1. Every time if you release the xmlXPathFreeContext(self->xpath_ctx);, this function does not release the processed self->xpath_ctx->doc, but it must be:

if (self->xpath_ctx && self->xpath_ctx->doc)
    xmlFreeDoc(self->xpath_ctx->doc);

2. In gc_web_service_get_string(), g_strdup does not need:

*value = g_strdup ((char*)xmlXPathCastNodeSetToString (obj->nodesetval));

->

*value = (char*)xmlXPathCastNodeSetToString (obj->nodesetval);

Such bugs can be avoided using unit tests+valgrind.

Cheers!
  kecsap
Comment 1 Jussi Kukkonen [inactive] 2008-12-10 12:20:12 UTC 
Thanks Csaba, fixes are in git.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.