Created attachment 21121 [details] [review] Patch against 10-usb-music-players.fdi I've reviewed in 10-usb-music-players.fdi all information about Cowon iAUDIO players, and I've found several mistakes. I'm myself the owner of a M3, and I had noticed its folders were not set right I've split the common entry for M3, X5, M5, 5, G2 into several sections, because they don't use the same file structure nor support the same formats. I've been parsing the manuals from Cowon to find out how they work, and I think I've managed to get all the informations needed. Though, I can only be completely sure of the informations about the M3, I could not check for other (even if it should be good). In particular: - I'm not sure the product_id for iAUDIO 5 are 0x602 and 0x604. Those numbers are strange to me as they don't seem to follow any logical rule. Anyway, I'm sure of these IDs for the other players, so these must be the right ones. If somebody could check, it could be nice. - I'm not sure that the iAUDIO G* series uses or doesn't use a MUSIC/ folder separate from the root. Older iAUDIOs do, others simply use the root folder for that. I've guessed from the manual, but I could not correct every error - anyway it should be better than before. And I've added audio/mpeg in output_formats for all players, since they read MP3 and that was only included in input_formats (or maybe it is implicitly set?). Please ask if you need a check or something. I'd really like these players to work, since they're quite popular in the FOSS world: they read OGG and FLAC (!). Keep up the good work!
Would somebody review and (hopefully) commit this? It's been two months... Thanks!
commit da022f3321f0859dd6410cc097ec8eb8960dcd9b Author: Milan Bouchet-Valat <nalimilan@club.fr> Date: Mon Feb 2 12:56:49 2009 +0100 fix Cowon iAUDIO music players Fixed Cowon iAUDIO music players. From https://bugs.freedesktop.org/show_bug.cgi?id=19069: > I've reviewed in 10-usb-music-players.fdi all information about Cowon iAUDIO > players, and I've found several mistakes. I'm myself the owner of a M3, and I > had noticed its folders were not set right > I've split the common entry for M3, X5, M5, 5, G2 into several sections, > because they don't use the same file structure nor support the same formats. > I've been parsing the manuals from Cowon to find out how they work, and I think > I've managed to get all the informations needed. > Though, I can only be completely sure of the informations about the M3, I could > not check for other (even if it should be good). In particular: > - I'm not sure the product_id for iAUDIO 5 are 0x602 and 0x604. Those numbers > are strange to me as they don't seem to follow any logical rule. Anyway, I'm > sure of these IDs for the other players, so these must be the right ones. If > somebody could check, it could be nice. > - I'm not sure that the iAUDIO G* series uses or doesn't use a MUSIC/ folder > separate from the root. Older iAUDIOs do, others simply use the root folder for > that. I've guessed from the manual, but I could not correct every error - > anyway it should be better than before.
commit bc6c15868c5543a9f1756681e0d70f4a7b35a20d Author: Danny Kukawka <danny.kukawka@web.de> Date: Mon Feb 2 12:59:36 2009 +0100 cleaned up Cowon iAUDIO music players Cleaned up Cowon iAUDIO music players. - Removed not needed audio/mpeg from output_formats, the entry get added anyway for all mp3 players. - put common players together, handle different path (music, playlist) information in submatches.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.