Bug 1909 - build is not independent of vgahw
Summary: build is not independent of vgahw
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: All All
: high major
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-23 02:56 UTC by Daniel Stone
Modified: 2005-10-22 19:40 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
relatively straightforward patch (8.22 KB, patch)
2004-11-23 02:57 UTC, Daniel Stone 		no flags Details | Splinter Review
View All

Description Daniel Stone 2004-11-23 02:56:48 UTC 
While the radeon and r128 modules depend on vgahw in a very big way, they are
still all built if vgahw is not being built (e.g. you're building on SPARC). 
This breaks builds of static servers with drivers/ati being built, but vgahw
not.  The attached patch (Debian/Ubuntu #024, present for over a year, no
problems, etc, etc) fixes this issue.
Comment 1 Daniel Stone 2004-11-23 02:57:36 UTC 
Created attachment 1357 [details] [review]
relatively straightforward patch
Comment 2 Ian Romanick 2004-11-23 09:34:06 UTC 
Comment on attachment 1357 [details] [review]
relatively straightforward patch

If building without vgaHW were the default on PowerPC, this would also fix bug
#1654.
Comment 3 Daniel Stone 2004-11-23 10:59:10 UTC 
Comment on attachment 1357 [details] [review]
relatively straightforward patch

make roland less angry
Comment 4 Michel Dänzer 2004-11-29 22:19:33 UTC 
(In reply to comment #2)
> (From update of attachment 1357 [details] [review] [edit])
> If building without vgaHW were the default on PowerPC, this would also fix bug
> #1654.

But it would be wrong, as some PPC machines actually need it.
Comment 5 Alex Deucher 2004-12-19 14:48:47 UTC 
see bugs 2089, 2064
Comment 6 T. Hood 2005-10-04 06:30:29 UTC 
I see that the patch has been applied to CVS.
Comment 7 Adam Jackson 2005-10-23 12:40:59 UTC 
applied to head, marking as fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.