Bug 1910 - wacom: horrifically out of sync from upstream
Summary: wacom: horrifically out of sync from upstream
Status: RESOLVED WONTFIX
Alias: None
Product: xorg
Classification: Unclassified
Component: Input/other (show other bugs)
Version: git
Hardware: All All
: lowest minor
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
: 366 1917 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-23 03:04 UTC by Daniel Stone
Modified: 2005-07-16 00:25 UTC (History)
5 users (show)

See Also:
i915 platform:
i915 features:


Attachments
huge, but very well-tested, patch (356.34 KB, patch)
2004-11-23 03:05 UTC, Daniel Stone
no flags Details | Splinter Review

Description Daniel Stone 2004-11-23 03:04:38 UTC
(Using sev:critical within the context of the Wacom driver, not within the
context of the entire release.)

The current Wacom driver in the tree is, to put it bluntly, broken to hell.  It
does not support most tablets made within the last three or four years -- if it
recognises them, it declares them to be 0x0, or just does random things with
input, or whatever.

This driver is upstream maintained at linuxwacom.sf.net, and they have a new
driver that has been present in both Debian and Ubuntu for quite some time now.
 We have had zero bug reports about tablets since incorporating it, and about
seven 'doesn't work whatsoever' reports before doing it.

Since there is no parallel development going on and it has been well-tested by
most distributions (I believe Red Hat incorporates it also), please, please,
incorporate it for the next release, or drop the Wacom driver from the tree.
Comment 1 Daniel Stone 2004-11-23 03:05:38 UTC
Created attachment 1358 [details] [review]
huge, but very well-tested, patch
Comment 2 Daniel Stone 2004-11-23 10:58:58 UTC
Comment on attachment 1358 [details] [review]
huge, but very well-tested, patch

make roland less angry
Comment 3 Kristian Høgsberg 2004-11-23 18:41:46 UTC
(In reply to comment #0)
> Since there is no parallel development going on and it has been well-tested by
> most distributions (I believe Red Hat incorporates it also), please, please,
> incorporate it for the next release, or drop the Wacom driver from the tree.

We actually package the linuxwacom.sf.net drivers seperately in the linuxwacom
rpm and disable the in-tree wacom drivers.  I think this is the better way to
go, with the modularization on the horizon.  I would expect that the in-tree
driver just goes away when we modularize the distribution, and linuxwacom.sf.net
becomes the oficially sanctioned wacom driver.

While I think the code drop is a bit much for a point-release, I don't see it
affecting the overall server stability, and I agree that you probably can't
break the in-tree driver more than it already is.
Comment 4 Donnie Berkholz 2004-11-27 17:38:32 UTC
It's worth checking out the discussion in bug #366 when considering this.
Comment 5 Daniel Stone 2004-11-27 18:04:57 UTC
> We actually package the linuxwacom.sf.net drivers seperately in the linuxwacom
> rpm and disable the in-tree wacom drivers.  I think this is the better way to
> go, with the modularization on the horizon.  I would expect that the in-tree
> driver just goes away when we modularize the distribution, and linuxwacom.sf.net
> becomes the oficially sanctioned wacom driver.

We just have it in our #000_* patches, which we don't really count in our 'how
many patches do we have' count, as they're typically taken from upstream anyway.
 While I agree that pointing people to linuxwacom is the way to go in terms of
modularisation, the fact that the Wacom there is there by default indicates that
it's there to be used and it works, and I believe it should either be dropped,
or made vaguely useful.
Comment 6 Daniel Stone 2004-12-01 11:11:07 UTC
Are there any objections?
Comment 7 Adam Jackson 2004-12-01 19:39:57 UTC
only that bug #1917 conflicts...
Comment 8 Daniel Stone 2005-03-10 19:37:23 UTC
*** Bug 1917 has been marked as a duplicate of this bug. ***
Comment 9 Daniel Stone 2005-03-10 19:37:56 UTC
i'm going to merge this at some point
Comment 10 Daniel Stone 2005-03-10 19:38:08 UTC
i'm going to merge this at some point
Comment 11 Adam Jackson 2005-03-26 18:58:32 UTC
*** Bug 366 has been marked as a duplicate of this bug. ***
Comment 12 Adam Jackson 2005-03-26 19:00:27 UTC
while this will be addressed in future modular releases by just making
linuxwacom.sf.net the official driver, we still need to resolve this for 7.0,
either by merging daniel's patch or by dropping our copy of the wacom driver.

just a friendly reminder.
Comment 13 Daniel Stone 2005-06-04 05:23:49 UTC
If no-one has any objections, I think we should drop our version.
Comment 14 Adam Jackson 2005-06-07 16:45:21 UTC
marked as deprecated on the wiki:

http://xorg.freedesktop.org/wiki/DeprecatedInX11R7

leaving open until 7.0 release on the off chance that someone has a convincing
argument for updating our version.
Comment 15 Mike Auty 2005-07-17 08:38:10 UTC
Hi,

I just saw this bug whilst investigating possible reasons for relative mode not
working with the 2.6.13_rc1,2,3 kernels.  Anyway, during my investigations I
found that linuxwacom apparently still doesn't support dlloader.  Not only is
dlloader slated to be the default module loading method in new Xorgs, but also
it's the only way to load modules on a pic/pie hardened system.  Therefore,
until this is implemented in linuxwacom I'd recommend not deprecating the
in-built version which does appear to build and work with dlloader.  Thanks,

Mike  5:)
Comment 16 Adam Jackson 2005-07-17 10:25:38 UTC
dlloader support will take care of itself, in my opinion.  someone will try to
use linuxwacom with 6.9/7.0, notice that it fails, and run the ld magic to
convert it to dlloader format.  it's really quite trivial.

with that said: the wacom driver is autotooled for 7.0, but is still being
marked deprecated, and will not be updated to match linuxwacom.  closing.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.