Bug 1931 - DDC data in server-generated config file bogus.
Summary: DDC data in server-generated config file bogus.
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/DDX/Xorg (show other bugs)
Version: 6.8.1
Hardware: All All
: high normal
Assignee: Egbert Eich
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-26 06:10 UTC by Egbert Eich
Modified: 2004-12-14 02:24 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[FIXED_X11R68x] Fix (1.06 KB, patch)
2004-11-26 06:11 UTC, Egbert Eich
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Egbert Eich 2004-11-26 06:10:04 UTC
The fix removes unused DDC sections that caused misinterpretation of
DDC data due to a missing break statement in a switch.
Already committed to head. Submitted for nomination for 6.8.2.
Comment 1 Egbert Eich 2004-11-26 06:11:30 UTC
Created attachment 1390 [details] [review]
[FIXED_X11R68x] Fix

For 6.8.2 nomination only.
Comment 2 Egbert Eich 2004-12-06 10:28:10 UTC
Most of this patch does cosmetics. The real fix is here:

-	      break;
-	    case DS_ASCII_STR:
-	    case DS_SERIAL:
+		break;
 	    case DS_RANGES:
case DS_ASCII_STR and DS_SERIAL where processed like DS_RANGES due to a missing
break. To prevent this in the future and to make the code more readable the
cosmetics were done.
Comment 3 Roland Mainz 2004-12-11 15:27:16 UTC
Comment on attachment 1390 [details] [review]
[FIXED_X11R68x] Fix

Approval for X11R6.8.x stable branch granted in the 2004-12-08
release-wranglers phone call.
Please don't commit, I'll do that myself...
Comment 4 Roland Mainz 2004-12-14 21:24:06 UTC
Comment on attachment 1390 [details] [review]
[FIXED_X11R68x] Fix

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.75; previous revision: 1.365.2.74
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/common/xf86Configure.c,v  <-- 
xf86Configure.c
new revision: 1.6.2.1; previous revision: 1.6
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 5 Roland Mainz 2004-12-14 21:24:49 UTC
Patch checked-in into Xorg trunk and X11R6.8.x stable branch...

... marking bug as FIXED.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.