Bug 1958 - [6.8.x] libXft crash when freeing fonts
Summary: [6.8.x] libXft crash when freeing fonts
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xft (show other bugs)
Version: 6.8.2
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 7247
  Show dependency treegraph
 
Reported: 2004-11-29 01:42 UTC by James Henstridge
Modified: 2011-10-15 15:33 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
xftreleasefile-crash.patch (1.07 KB, patch)
2005-04-22 10:01 UTC, Mike A. Harris
no flags Details | Splinter Review
xorg-x11-6.8.2-xft-releasefile-crash.patch (686 bytes, patch)
2005-04-25 08:34 UTC, Mike A. Harris
mharris: 6.8-branch?
Details | Splinter Review

Description James Henstridge 2004-11-29 01:42:24 UTC
I found a crasher bug in libXft that has now been fixed in the standalone
libXft.  The bug appears to be in the Xorg tree, so it is probably worth fixing
it there too.

A description of the problem and the patch can be found attached to bug 1951
Comment 1 James Henstridge 2004-11-30 18:08:24 UTC
I created this separate bug ticket because the person who originally reported
the problem to me was using the Xft from Xorg.

Looking at viewcvs, it looks like the bug is present still in rev 1.3, which was
included in Xorg 6.8.0 and 6.8.1:
  http://cvs.freedesktop.org/xorg/xc/lib/Xft/xftfreetype.c?view=log
Comment 2 Keith Packard 2004-11-30 21:32:17 UTC
Right.  We probably need to release a version of Xft with the fix and then push
that downstream into the X.org tree.

(/me is looking forward to skipping the latter part of that process at some point)
Comment 3 Keith Packard 2005-03-01 21:52:10 UTC
It appears that this bug has been fixed in the canonical Xft sources and remains
a problem only in downstream packages.
Comment 4 James Henstridge 2005-03-02 06:12:09 UTC
Should this really be marked resolved?

I realise that it has been fixed in standalone Xft (I filed the original bug
report against standalone Xft).  This bug report is against Xorg instead, where
it still seems to be broken.

In order for this bug to be resolved, Xorg would either need to merge in the fix
or stop repackaging libXft :)
Comment 5 Mike A. Harris 2005-04-22 09:58:49 UTC
No, it shouldn't be resolved, because it is a real world bug in Xft, which
is also part of Xorg.  If Xorg isn't going to fix bugs in Xft, then it
shouldn't include Xft.

I'm reopening this as I think it should be fixed in 6.8.2 with the patch
attached to bug #1951

https://bugs.freedesktop.org/attachment.cgi?id=1411
Comment 6 Mike A. Harris 2005-04-22 09:59:44 UTC
In fact, it makes no sense to have an xorg "Lib/Xft" bug component if
people just close bugs filed here as NOTOURBUG.
Comment 7 Mike A. Harris 2005-04-22 10:01:16 UTC
Created attachment 2512 [details] [review]
xftreleasefile-crash.patch
Comment 8 Mike A. Harris 2005-04-25 08:32:27 UTC
Comment on attachment 2512 [details] [review]
xftreleasefile-crash.patch

Patch fails to apply due to whitespace differences.  Marking attachment
obsolete as I'm adding an updated patch next.
Comment 9 Mike A. Harris 2005-04-25 08:34:57 UTC
Created attachment 2541 [details] [review]
xorg-x11-6.8.2-xft-releasefile-crash.patch
Comment 10 James Henstridge 2005-06-21 01:06:21 UTC
Is this any closer to getting accepted?  This bug causes the Gnome font
previewer to consistently crash, so it isn't just a theoretical bug that may
affect applications.
Comment 11 Alan Coopersmith 2005-07-01 16:11:25 UTC
libXft has been upgraded to Xft 2.1.7 in the Xorg monolithic tree CVS HEAD,
including this fix, so I'm going to mark it as RESOLVED: FIXED.

The patch remains an option for 6.8.3 should that ever happen.
Comment 12 Mike A. Harris 2005-07-05 16:44:40 UTC
It'll never get fixed in 6.8.3 if the bug is closed.
Comment 13 Daniel Stone 2007-02-27 01:24:41 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 14 Alan Coopersmith 2008-04-16 15:21:21 UTC
6.8.3 never happened, nor are any more monolith updates planned, so closing now.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.