Bug 1963 - PCI probe on Linux fails if bus 0 isn't populated
Summary: PCI probe on Linux fails if bus 0 isn't populated
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/DDX/Xorg (show other bugs)
Version: 6.8.1
Hardware: All Linux (All)
: high normal
Assignee: Egbert Eich
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-30 00:15 UTC by Egbert Eich
Modified: 2004-12-14 02:49 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[FIXED_X11R68x] Fix (1.02 KB, patch)
2004-11-30 00:18 UTC, Egbert Eich
roland.mainz: 6.8-branch+
Details | Splinter Review

Description Egbert Eich 2004-11-30 00:15:41 UTC
The OS specific PCI probing code for Linux has a heuristic to check for the
presence of /proc/bus/pci/00. This only works if bus 0 is really populated which
may not always be the case.
Comment 1 Egbert Eich 2004-11-30 00:18:33 UTC
Created attachment 1424 [details] [review]
[FIXED_X11R68x] Fix

Attached fix probes for presence of /proc/bus/pci/<bus_num>,
using the bus number we want to probe.
Comment 2 Egbert Eich 2004-11-30 00:43:59 UTC
Fixed in CVS head.
Comment 3 Roland Mainz 2004-12-08 05:54:56 UTC
Comment on attachment 1424 [details] [review]
[FIXED_X11R68x] Fix

Approved in the 2004-12-06 release-wranglers conference call.
Please do not commit it yourself, I'll do that later today...
Comment 4 Roland Mainz 2004-12-14 21:48:40 UTC
Comment on attachment 1424 [details] [review]
[FIXED_X11R68x] Fix

Patch checked-in into X11R6.8.x stable branch:

/cvs/xorg/xc/ChangeLog,v  <--  ChangeLog
new revision: 1.365.2.77; previous revision: 1.365.2.76
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/programs/Xserver/hw/xfree86/os-support/bus/linuxPci.c,v  <-- 
linuxPci.c
new revision: 1.3.4.1; previous revision: 1.3
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.