Bug 19687 - Add XK_ names for U+0292 (ezh), U+01B7 (Ezh) and U+2030 (per mille) to keysymdef.h
Summary: Add XK_ names for U+0292 (ezh), U+01B7 (Ezh) and U+2030 (per mille) to keysym...
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (data) (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL: http://kotoistus.tksoft.com/linux/sym...
Whiteboard: 2011BRB_Reviewed
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-22 05:23 UTC by Troy Korjuslommi
Modified: 2012-02-21 06:23 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
0001-x11proto-add-permille-ezh-and-EZH-to-keysymdef.h.patch (3.34 KB, patch)
2012-02-20 23:32 UTC, Marko Myllynen
no flags Details | Splinter Review
0001-i18n-Provide-translation-from-XK_permille-ad5-to-Uni.patch (1.40 KB, patch)
2012-02-20 23:32 UTC, Marko Myllynen
no flags Details | Splinter Review
0001-Use-ezh-EZH-in-compose-maps.patch (4.17 KB, patch)
2012-02-20 23:32 UTC, Marko Myllynen
no flags Details | Splinter Review

Description Troy Korjuslommi 2009-01-22 05:23:19 UTC
The Finnish keyboard layout has the following characters which are specified using their Unicode values. I would like to add names for them in keysymdef.h.

The new entry could be something like:

#define XK_ezh                   0x???? /* U+0292 LATIN SMALL LETTER EZH */
#define XK_Ezh                   0x???? /* U+01B7 LATIN CAPITAL LETTER EZH */
#define XK_permille              0x???? /* U+2030 PER MILLE SIGN */
Comment 1 James Cloos 2009-01-22 12:58:04 UTC
I’ll look into this, but note that the general preference is to use
the UXXXX symbols rather than add new mnemonic symbols in most cases.
Comment 2 Troy Korjuslommi 2009-01-23 02:39:29 UTC
Yes, I am aware of that. After all, it is only a question of readability to have the aliases available. I don't know what criteria you use for inclusion in the file, so I felt it was best we at least propose these characters for inclusion. 
The characters are part of the Finnish standard; ezh is used in Sami, and the permille sign is used commonly in Finland, probably in other countries as well. 

I will leave the decision up to you.
Comment 3 Marko Myllynen 2011-02-21 03:12:35 UTC
Hi James,

may I ask have you made any decisions with this one yet?

Thanks.
Comment 4 Jeremy Huddleston Sequoia 2011-10-03 20:59:55 UTC
Can you please send a patch to xorg-devel for review?  That will make it more 
likely for inclusion.
Comment 5 Marko Myllynen 2011-10-04 00:12:33 UTC
Patch sent for review:

http://lists.x.org/archives/xorg-devel/2011-October/026015.html
Comment 6 Marko Myllynen 2012-01-19 00:34:43 UTC
The patch has received Reviewed-by approval, the updated version is at:

http://lists.x.org/archives/xorg-devel/2011-October/026499.html
Comment 7 James Cloos 2012-02-18 16:35:58 UTC
I’m trying to catch up with old patches.  (Things were most difficult
when my laptop failed; it took a while of extra work to save enough to
get a usable screen to replace it.)

Given that, AFAICT, no objections were raised on xorg-devel I will push
them, but the patches are now out of date and lack the Reviewed-by and
Signed-off-by lines.

The x11proto patch needs an update to the specs/keysyms.xml chunk and
the Use-ezh-EZH-in-compose-maps patch failed in the Compose.pre file(s).
Comment 8 Marko Myllynen 2012-02-20 23:31:06 UTC
James, thanks for looking into this.

I'm attaching the updated patches, now applying cleanly against git masters and with Signed-off-by and Reviewed-by lines, the latter based on:

http://lists.x.org/archives/xorg-devel/2011-October/026558.html

Thanks.
Comment 9 Marko Myllynen 2012-02-20 23:32:00 UTC
Created attachment 57373 [details] [review]
0001-x11proto-add-permille-ezh-and-EZH-to-keysymdef.h.patch
Comment 10 Marko Myllynen 2012-02-20 23:32:23 UTC
Created attachment 57374 [details] [review]
0001-i18n-Provide-translation-from-XK_permille-ad5-to-Uni.patch
Comment 11 Marko Myllynen 2012-02-20 23:32:43 UTC
Created attachment 57375 [details] [review]
0001-Use-ezh-EZH-in-compose-maps.patch
Comment 12 James Cloos 2012-02-21 06:23:50 UTC
Thanks.

All three patches are pushed.

x11proto: commit  ab1fba1a0967
libX11:   commits 61725822f20f and 2ca641c3a506


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.