Bug 19980 - intel: build errors when --disable-dri specified
Summary: intel: build errors when --disable-dri specified
Status: RESOLVED WONTFIX
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/intel (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium major
Assignee: Wang Zhenyu
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-06 00:33 UTC by Ilia Sotnikov
Modified: 2009-07-10 13:26 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
The patch fixes the compilation when --disable-dri passed to configure (23.16 KB, patch)
2009-03-02 11:17 UTC, Ilia Sotnikov
no flags Details | Splinter Review

Description Ilia Sotnikov 2009-02-06 00:33:11 UTC
Intel driver build failed (tried 2.4.3 and 2.6.1) when --disable-dri passed to 'configure'. The errors are (from 2.6.1):

...
In file included from i830.h:80,
                 from i810_driver.c:88:
/usr/include/intel_bufmgr.h:92: error: expected declaration specifiers or ‘...’ before ‘drm_clip_rect_t’
In file included from i810_driver.c:88:
i830.h:734: error: expected specifier-qualifier-list before ‘drmmode_rec’
In file included from i830.h:766,
                 from i810_driver.c:88:
i830_batchbuffer.h:46: error: expected declaration specifiers or ‘...’ before ‘GLuint’
i830_batchbuffer.h: In function ‘intel_batch_require_space’:
i830_batchbuffer.h:49: error: ‘sz’ undeclared (first use in this function)
i830_batchbuffer.h:49: error: (Each undeclared identifier is reported only once
i830_batchbuffer.h:49: error: for each function it appears in.)
i830_batchbuffer.h: In function ‘intel_batch_start_atomic’:
i830_batchbuffer.h:59: error: too many arguments to function ‘intel_batch_require_space’
i810_driver.c: In function ‘I810ScreenInit’:
i810_driver.c:2389: warning: unused variable ‘driFrom’
make[6]: *** [i810_driver.lo] Error 1
Comment 1 Eric Anholt 2009-02-10 17:25:24 UTC
We don't actively support disabling DRI, but accept patches to fix it currently (this will change at some point).
Comment 2 Ilia Sotnikov 2009-03-02 11:17:40 UTC
Created attachment 23448 [details] [review]
The patch fixes the compilation when --disable-dri passed to configure

The attached patch fixes the compilation when --disable-dri passed to configure. Perhaps the approach totally broken, but at least the driver works (only tried with --disable-dri)
Comment 3 Michael Fu 2009-03-12 18:45:49 UTC
comments, zhenyu?
Comment 4 Wang Zhenyu 2009-03-12 18:51:34 UTC
I'd like to remove --disable-dri option than having this kind of patch.
Comment 5 Eric Anholt 2009-07-10 13:26:50 UTC
I think we're in agreement that we don't want to support a non-DRI path, and patches since 2.7 have taken us further down that path.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.