Bugzilla – Bug 20253
dbus-daemon-launch-helper: fix build with libxml
Last modified: 2013-06-06 12:03:29 UTC
Created attachment 23179 [details] [review]
I know the libxml support is deprecated, but here goes:
dbus-daemon-launch-helper links with the trival config parser, which
doesn't provide bus_config_parser_check_doctype(), like the big parser does.
The libxml loader unfortunately wants to call it, so this breaks the build.
Fix it by including a dummy bus_config_parser_check_doctype() in the trivial
I'm curious, why do you use the libxml backend? If there's a good reason to keep it, we should apply fixes like these and ensure that it's regression-tested; if there isn't, we should just delete it.
(In reply to comment #1)
> I'm curious, why do you use the libxml backend? If there's a good reason to
> keep it, we should apply fixes like these and ensure that it's
> regression-tested; if there isn't, we should just delete it.
Well, this is for buildroot (http://buildroot.net), which is a build system for small embedded systems. Libxml2 was supported in the past, so we provide the option to use this for situations where libxml2 is already needed for other packages and expat isn't (libxml2 seems to be more commonly used by other packages than expat these days).
But OK, if there's no interest in supporting it, then yeah, let's get rid of it completely. Libexpat is quite small anyway (~150kb).
Created attachment 80384 [details] [review]
[PATCH] XML: hard depends on expat and delete libxml