Bug 20425 - Variant Thinkpad for Brazilian layout is gone
Summary: Variant Thinkpad for Brazilian layout is gone
Status: RESOLVED FIXED
Alias: None
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: xkb
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-02 07:32 UTC by Marco Túlio Gontijo e Silva
Modified: 2009-03-03 14:29 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Git patch that corrects this bug (1001 bytes, patch)
2009-03-02 07:32 UTC, Marco Túlio Gontijo e Silva
Details | Splinter Review
Patch to add thinkpad variant for br in models thinkpad60 and thinkpadz60 (1.24 KB, patch)
2009-03-03 04:01 UTC, Marco Túlio Gontijo e Silva
Details | Splinter Review

Description Marco Túlio Gontijo e Silva 2009-03-02 07:32:54 UTC
Created attachment 23442 [details] [review]
Git patch that corrects this bug

I don't know why, but the variant for the Brazilian keyboard "thinkpad" is gone in version 1.5, and it was present in version 1.3.  Notice that it's gone only in base.xml.in, and it's present in symbols/br.  This patch reincludes it in base.xml.in.

Greetings.
Comment 1 Sergey V. Udaltsov 2009-03-02 12:33:11 UTC
I removed that layout from base.xml.in for a reason. There is no need to have this variant explicitly published. When user choses model thinkpad + layout 'br', the variant br(thinkpad) is chosen automatically. Look at the rules/base file.
Comment 2 Marco Túlio Gontijo e Silva 2009-03-03 04:01:06 UTC
Created attachment 23469 [details] [review]
Patch to add thinkpad variant for br in models thinkpad60 and thinkpadz60
Comment 3 Sergey V. Udaltsov 2009-03-03 14:29:03 UTC
I've slightly improved your patch and committed.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.