Bug 20427 - cairommconfig.h contains non-prefixed definitions
Summary: cairommconfig.h contains non-prefixed definitions
Status: RESOLVED FIXED
Alias: None
Product: cairomm
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Murray Cumming
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-02 07:50 UTC by Armin Burgmeier
Modified: 2009-12-31 07:21 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Proposed patch (4.66 KB, patch)
2009-03-02 07:50 UTC, Armin Burgmeier 		Details | Splinter Review
View All

Description Armin Burgmeier 2009-03-02 07:50:51 UTC 
Created attachment 23446 [details] [review]
Proposed patch

cairommconfig.h contains several definitions such as PACKAGE or VERSION that can conflict with other projects. cairommconfig.h should only contain prefixed definitions, and there should be a separate (private) config.h for non-prefixed definitions.

The attached patch changes this and takes care that <config.h> is included instead of <cairommconfig.h> where appropriate.
Comment 1 Matteo Settenvini 2009-12-31 05:51:39 UTC 
Hi, I've just migrated my project to using gtkmm+cairomm from using gtkmm+cairo. Since I use those variables internally too, I'm stuck with this bug throwing at me a lot of compiler warnings; can this patch be committed?

Thanks!
Comment 2 Jonathon Jongsma 2009-12-31 07:21:55 UTC 
sorry, I forgot to close this bug.  A similar but slightly different fix was already included in 1.8.4.  So if you can update to that version, it should fix your problems.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.