Bug 2047 - Use of wbinvd() macro
Summary: Use of wbinvd() macro
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Ext/GLX (show other bugs)
Version: git
Hardware: Other Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-10 03:32 UTC by Stefan Dirsch
Modified: 2005-04-15 17:55 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
ati-pcigart.diff (325 bytes, patch)
2004-12-10 03:38 UTC, Stefan Dirsch
no flags Details | Splinter Review

Description Stefan Dirsch 2004-12-10 03:32:45 UTC
in km_drm/ati_pcigart.h, there's assembly code to call the 
wbinvd (write back cache flush and invalidate) assembly insn 
on i386 and x86-64. 
 
The kernel offers to do this with the macro wbinvd() just as well. 
The advantage is that it would still even work on Xen which redefines 
the wbinvd() call according to it's needs.
Comment 1 Stefan Dirsch 2004-12-10 03:38:47 UTC
Created attachment 1505 [details] [review]
ati-pcigart.diff
Comment 2 Stefan Dirsch 2004-12-10 03:41:05 UTC
Dave, could you have a look at this one, please? 
Comment 3 Dave Airlie 2004-12-10 03:51:20 UTC
Looks fine to me, how urgent is it? I'll push it to Linus after 2.6.10 is
released (with the drm re-organisation..) if not, if it is I can probably push
it now...
Comment 4 Stefan Dirsch 2004-12-10 04:56:14 UTC
Sorry, I need to ask the author of the patch (Kurt Garloff) first ... 
Comment 5 Stefan Dirsch 2004-12-10 05:02:50 UTC
Just got a response by Kurt. He told me that it's not urgent at all. We would 
like to have it upstream in early 2005, so we can get rid of the the hack for 
our kernel-xen specfile for the next SuSE release. 
Comment 6 Stefan Dirsch 2005-04-16 10:55:03 UTC
This is already fixed in current kernel sources (2.6.11 ATM). ==> FIXED 


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.