Bug 20541 - i128 driver doesn't properly unmap things with libpciaccess
Summary: i128 driver doesn't properly unmap things with libpciaccess
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/i128 (show other bugs)
Version: git
Hardware: All All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-08 11:12 UTC by Mark Kettenis
Modified: 2009-05-04 12:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Fix (1.00 KB, patch)
2009-03-08 11:13 UTC, Mark Kettenis 		no flags Details | Splinter Review
View All

Description Mark Kettenis 2009-03-08 11:12:19 UTC 
If the xf86-vide-i128 is compiled with XSERVER_LIBPCIACCESS, registers and frmaebuffer memory are mapped through libpciaccess.  However, I128UnmapMem tries to unmap things vy using xf86UnmapVidMem.  This fails because the memory isn't
registered (which only happens if you mapped the memory using xf86MapPciMem.  The attached diff fixes this.
Comment 1 Mark Kettenis 2009-03-08 11:13:05 UTC 
Created attachment 23656 [details] [review]
Fix
Comment 2 Tormod Volden 2009-03-10 00:39:42 UTC 
Mark, thanks for the patch. Reports in https://bugs.launchpad.net/bugs/306970 confirms that your patch fixes the crash on start-up.

However, the computer freezes when startx is run a second time. Could this be another memory (un)map problem?
Comment 3 Matthieu Herrb 2009-05-04 12:58:43 UTC 
Thanks. Pushed commit cee4cdf061ca8e6376846c0eac2fc6d57711129e.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.