Created attachment 23671 [details] [review] de.diff Forwarding this bug from a Ubuntu reporter: https://bugs.edge.launchpad.net/ubuntu/+source/xkeyboard-config/+bug/59572 [Problem] Low quote marks can't be set in German keyboards. Attached patch adds them to AltGr+V, and shifts the English quote marks to AltGr+B and AltGr+N. [Original Report] „ (U+201E DOUBLE LOW-9 QUOTATION MARK) is often used in German as an open quotation mark, with “ as the closing mark (English-style quotes are used too, as well as guillemets, but these are traditional). You can set things like OOo to use this style instead of ", but plain text things have no way to enter it. I'd suggest (depending on input from people who actually type German regularly) assigning the German "pretty quotes" to AltGr-V and AltGr-B („ and “ respectively). Alt Gr + V should generate "„" and Alt Gr + Shift + V should generate a single lower quote. The English Left Quotes could move one key to the right, N is unmapped in both Alt Gr and Alt Gr + Shift. This patch adds the low quotation marks to AltGr+v, and shifts the English quotation marks to AltGr+b and AltGr+n as suggested. I've tested this and it seems to work.
Just out of curiosity - do these mappings exist in MSWin or MacOSX keyboards? Are you sure there are no higher priority candidates amont German-typinh users? It would be pity to find that something more important should be put on these places.
(In reply to comment #1) > Just out of curiosity - do these mappings exist in MSWin or MacOSX keyboards? > Are you sure there are no higher priority candidates amont German-typinh users? > It would be pity to find that something more important should be put on these > places. > 1. There is no mapping at all in any MS system 2. There is a mapping in osx, but that layout breaks german industrial standard DIN 2137. What’s more, there is a german Mac layout available for X11, so that mapping should go there. I have found various alternate layouts for Windows, every of which have different mappings for qutoation marks. None of them have i seen in action till now, they don’t seem to be in widespread use. Using the above proposed mapping is logical, as it preserves the places for opening and closing quotationmarks as inherited from the default layout. If any other place be preferable, it would be near " (shift+2), but some places there are taken by DIN 2137. Keeping them on <alt gr>+<v> and <b> lets us put single quotation marks on the same keys. On improving the german layout, we should include some more changes: - Angle quotation marks are equally valid as curved ones (german order: »«; the Swiss use them pointing outwards, but there’s a separate swiss layout). The double ones are available (though in reversed order), but single ones aren’t. So I propose to include them on the 4th level above "»" and "«", where they replace "<" and ">" which are on the key to the left (<BKSL>), and to change the order of them to the german one (» and › on Y/<AB01>, « and ‹ on X). - Endash is very often used in german texts. I’d put it on 3rd level above the minushyphen (<AB10>), the emdash on 4th level. The two signs (deadbelowdot and deadabovedot, which aren’t used in german) from this position could be moved to places not yet assigned (e.g. J), or where lie signs that have more than one position. In the attached proposal, they lie on <J>. - In MS Word and Mac OS X, the ellipsis is accessed by <alt gr>/<alt>+<.>. This could be adopted easily. “Periodcentered”, which is there actually could replace “horizconnector” on <alt gr>+<,>. - In times of Google Earth and similar programs and/or GPS available on most devices, it shouldn’t be too hard to enter correctly formatted geographic measures. The prime (′) and double prime (″) signs used together with the degree sign could be put on 3rd and 4th level above "°" (<TLDE>), where at the moment lie two copies of "¬", which has a third copy on <alt gr>+<6>. - 3rd and 4th level of <S> are currently occupied by "ß" and "§", which both also have other positions in the layout (corresponding to the industrial standard). These positions could be given to ſ and ẞ (capital sharp s). - One could also think about putting the typographical accent "’" on <alt gr>+<#> (next to '), but that sign is the same as “rightsinglequotemark”, thus already availalbe in the proposal. As I don’t know how to make a diff, I attach the changed de file (yet without changes in nodeadkeys layouts).
Created attachment 23913 [details] [review] adapted symbols de file
To make a patch, just do diff -u oldfile newfile I do not like this part: - key <LSGT> { [ ISO_Level5_Shift ]}; - key <RALT> { [ ISO_Level5_Shift ]}; + // ISO_Level5_Shift was causing problems, though it's defined in + // /usr/include/X11/keysymdef.h on Ubuntu 8.10 (ticket #33), + // using hexcode again for now + key <LSGT> { [ 0xfe11 ]}; + key <RALT> { [ 0xfe11 ]}; In 8.10 I have that keysym: $ grep Level5_Shift /usr/include/X11/keysymdef.h #define XK_ISO_Level5_Shift 0xfe11 Also, this is somewhat suspicious: - key <AE07> { [ 7, dollar, yen, Greek_kappa, currency, NoSymbol, rightarrow ] }; + key <AE07> { [ 7, EuroSign, yen, Greek_kappa, currency, NoSymbol, rightarrow ] }; Would people be happy about changing dollar to Euro (even though Euro is a German currency)? Could you please make a patch - and make sure that every change is exactly what you want. Thanks!
(In reply to comment #4) > To make a patch, just do > diff -u oldfile newfile > > I do not like this part: > - key <LSGT> { [ ISO_Level5_Shift ]}; > - key <RALT> { [ ISO_Level5_Shift ]}; > + // ISO_Level5_Shift was causing problems, though it's defined in > + // /usr/include/X11/keysymdef.h on Ubuntu 8.10 (ticket #33), > + // using hexcode again for now > + key <LSGT> { [ 0xfe11 ]}; > + key <RALT> { [ 0xfe11 ]}; > > In 8.10 I have that keysym: > $ grep Level5_Shift /usr/include/X11/keysymdef.h > #define XK_ISO_Level5_Shift 0xfe11 > > Also, this is somewhat suspicious: > - key <AE07> { [ 7, dollar, yen, > Greek_kappa, currency, NoSymbol, rightarrow ] }; > + key <AE07> { [ 7, EuroSign, yen, > Greek_kappa, currency, NoSymbol, rightarrow ] }; > > Would people be happy about changing dollar to Euro (even though Euro is a > German currency)? > > Could you please make a patch - and make sure that every change is exactly what > you want. Thanks! > Sorry, that must have been confusing. What you commented on seems to be the NEO part, which has nothing to do with my patch. Thanks for your help, here’s the diff.
Created attachment 23920 [details] [review] new de.diff
That one is much cleaner! But it does not apply to the latest version of the file: $ patch -p1 < de.diff missing header for unified diff at line 3 of patch can't find file to patch at input line 3 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |--- /daten/Georg/de 2009-01-05 00:18:54.000000000 +0100 |+++ de 2009-03-16 13:57:08.000000000 +0100 -------------------------- File to patch: de patching file de patch: **** malformed patch at line 32:
Created attachment 23921 [details] [review] new de.diff that works
Great, that's better. Committed.
*** Bug 19934 has been marked as a duplicate of this bug. ***
*** Bug 16275 has been marked as a duplicate of this bug. ***
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.