Bug 20588 - Use PKG_PROG_PKG_CONFIG to check for pkg-config
Summary: Use PKG_PROG_PKG_CONFIG to check for pkg-config
Status: RESOLVED FIXED
Alias: None
Product: poppler
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: lowest enhancement
Assignee: poppler-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-10 14:46 UTC by Hib Eris
Modified: 2009-03-10 16:40 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch-1-Check_for_pkg-config_with_PKG_PROG_PKG_CONFIG (907 bytes, patch)
2009-03-10 14:46 UTC, Hib Eris
Details | Splinter Review

Description Hib Eris 2009-03-10 14:46:26 UTC
Created attachment 23736 [details] [review]
patch-1-Check_for_pkg-config_with_PKG_PROG_PKG_CONFIG

Since commit 7a5d1e57b2757c986da17f7238415b927e73127f poppler checks for pkg-config, but this hard-codes 'pkg-config' as the name of the pkg-config program. 

It is better to use PKG_PROG_PKG_CONFIG, as this will also check for the appropriate pkg-config program when cross compiling.
Comment 1 Albert Astals Cid 2009-03-10 16:40:30 UTC
Commited


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.