Bug 2090 - Automake 1.4 doesn't support package_CFLAGS syntax - breaks jhbuild run
Summary: Automake 1.4 doesn't support package_CFLAGS syntax - breaks jhbuild run
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: x86 (IA32) All
: high major
Assignee: Jonathan Blandford
QA Contact:
URL:
Whiteboard:
Keywords:
: 2235 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-12-16 03:52 UTC by Loïc Minier
Modified: 2005-04-15 20:11 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
fix Makefile.am (486 bytes, patch)
2004-12-16 03:54 UTC, Loïc Minier
Details | Splinter Review

Description Loïc Minier 2004-12-16 03:52:20 UTC
Hi,

I can't build shared-mime-info (I'm building with jhbuild) because the
Makefile.am seems broken:
- autogen.sh indicates automake 1.4 is desired (since the command "automake" is
run),
- Makefile.am uses update_mime_database_CFLAGS but automake1.4 doesn't know
about it.

I think this was introduced in revision 1.18, I'll attach a patch that still
uses externally defined CFLAGS and honors ALL_CFLAGS too.
Comment 1 Loïc Minier 2004-12-16 03:54:29 UTC
Created attachment 1554 [details] [review]
fix Makefile.am

Please adapt the patch to use LDFLAGS too if you need them (I didn't since the
CFLAGS are used in linking too) or remove the update_mime_database_LDADD.
Comment 2 Christophe Fergeau 2005-01-08 15:05:56 UTC
*** Bug 2235 has been marked as a duplicate of this bug. ***
Comment 3 Christophe Fergeau 2005-04-16 13:11:49 UTC
This was probably fixed by 
2005-04-07  Bastien Nocera  <hadess@hadess.net>
        * Makefile.am: work-around for old versions of automake

Please reopen this bug if you are still having problems.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.