Bug 21219 - [fixed in git] dbus_g_connection_unregister_g_object() needed
Summary: [fixed in git] dbus_g_connection_unregister_g_object() needed
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Rob Taylor
QA Contact: John (J5) Palmieri
URL:
Whiteboard:
Keywords: patch
Depends on: 5688
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-16 04:23 UTC by Simon McVittie
Modified: 2009-07-20 06:00 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Preparatory work on top of #5688 (store more info, needed to unregister) (2.25 KB, patch)
2009-04-16 05:02 UTC, Simon McVittie
Details | Splinter Review
implement unregistration (2.27 KB, patch)
2009-04-16 05:02 UTC, Simon McVittie
Details | Splinter Review
regression test (5.15 KB, patch)
2009-04-16 05:02 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2009-04-16 04:23:10 UTC
Currently, the only way to remove an exported object from the bus is to destroy it. In Telepathy, we've found that this is unwelcome - we often have objects that were meant to be removed from the bus (e.g. a channel that has closed), but are temporarily kept alive by an extra reference held by a sub-object or a pending asynchronous operation.

It would be good to have a way to remove objects from the bus other than by their destruction. I believe that my patch for Bug #5688 is a good starting point for this.
Comment 1 Simon McVittie 2009-04-16 05:02:04 UTC
Created attachment 24856 [details] [review]
Preparatory work on top of #5688 (store more info, needed to unregister)
Comment 2 Simon McVittie 2009-04-16 05:02:22 UTC
Created attachment 24857 [details] [review]
implement unregistration
Comment 3 Simon McVittie 2009-04-16 05:02:39 UTC
Created attachment 24858 [details] [review]
regression test
Comment 4 Simon McVittie 2009-04-16 05:03:33 UTC
As with Bug #5688, this works in the context of dbus-glib's own `make check`, but I still need to run the telepathy-glib and telepathy-gabble test suites with this patch.
Comment 5 Simon McVittie 2009-04-16 05:24:28 UTC
My 'cumulative' git branch, which is the octopus merge of my branches to fix Bug #5688, Bug #13908, Bug #14579, Bug #16776, Bug #20716, Bug #20884, Bug #20886 and Bug #20936, passes its own regression tests, and also the telepathy-glib and telepathy-gabble regression tests.

(Patches in those branches were variously written by me, Tobias Mueller, Peter Korsgaard and Mikkel Kamstrup Erlandsen.)
Comment 6 Simon McVittie 2009-05-28 10:08:30 UTC
Pushed, thanks for the review (which was on Bug #5688).
Comment 7 Simon McVittie 2009-07-20 06:00:34 UTC
Fixed in 0.82, according to Colin's release mail.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.