Bug 21294 - Removing a group removes all contacts in that group
Summary: Removing a group removes all contacts in that group
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: haze (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard: r+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-04-20 05:39 UTC by Jonny Lamb
Modified: 2010-07-01 05:23 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Jonny Lamb 2009-04-20 05:39:42 UTC
I removed a group in Empathy and I thought it would remove contacts from that group, like all other CMs, but instead it just removed the contacts. This was on MSN.

13:22 < jonnylamb> wjt: However, I removed a group and it removed all the contacts in that group..
13:22 < wjt> jonnylamb: haha
13:22 < wjt> jonnylamb: i'm so sorry about groups
13:23 < wjt> jonnylamb: libpurple doesn't support contacts not being in a group
13:23 < wjt> jonnylamb: sounds like haze is violating “
13:23 < wjt> User-defined groups may be deleted by calling Close on the channel, but only if the group is already empty. Closing a channel to a non-empty group is not allowed; its members must be set to the 
             empty set first.”
13:24 < wjt> jonnylamb: (or Empathy is removing all the contacts)
Comment 1 Will Thompson 2009-08-17 10:19:39 UTC
I've just noticed that moving a contact from one group to another also deletes the contact. Empathy removes the contact from the first group before adding it to the second. Removing it from the first group also removes it from subscribe. Hilarity.
Comment 2 Will Thompson 2009-08-25 08:42:31 UTC
Just took a look at this. Empathy is removing all the contacts from the group (Haze won't let you close non-empty groups). But Haze should do some magic to prevent that deleting all your contacts.
Comment 3 Simon McVittie 2010-06-30 06:08:25 UTC
Haze will need porting to TpBaseContactList one day anyway, so I might as well try to make it saner on the way past.
Comment 4 Simon McVittie 2010-07-01 05:01:41 UTC
Fixed, with some tests.
Comment 5 Will Thompson 2010-07-01 05:10:44 UTC
looks good!
Comment 6 Simon McVittie 2010-07-01 05:23:13 UTC
Fixed in git for 0.3.6.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.