Bug 2142 - X server logs font path all one one very long unreadable line.
Summary: X server logs font path all one one very long unreadable line.
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords: janitor
Depends on:
Blocks: 3116
  Show dependency treegraph
 
Reported: 2004-12-23 11:58 UTC by Mike A. Harris
Modified: 2006-04-03 15:01 UTC (History)
4 users (show)

See Also:
i915 platform:
i915 features:


Attachments
this patch change the log output as described in the bug (1.25 KB, patch)
2006-01-28 07:52 UTC, Eduard Fuchs
no flags Details | Splinter Review

Description Mike A. Harris 2004-12-23 11:58:09 UTC
The X server logs the complete fontpath to the log, however it is
all on one very long line, which is rather unreadable.

(**) FontPath set to
"/usr/X11R6/lib/X11/fonts/75dpi:unscaled,/usr/X11R6/lib/X11/fonts/misc:unscaled,/usr/X11R6/lib/X11/fonts/misc,/usr/X11R6/lib/X11/fonts/Speedo,/usr/X11R6/lib/X11/fonts/TTF,/usr/X11R6/lib/X11/fonts/Type1,/usr/X11R6/lib/X11/fonts/hanyang,/usr/share/fonts/default/Type1,/usr/share/fonts/ko/saemmul,/usr/share/fonts/hanyang"

A nice minor enhancement to break this up on FPE boundaries would make the
font path more readable, and also help to spot font path related issues
in bug reports.

Something like:
(**) FontPath set to:
        /usr/X11R6/lib/X11/fonts/75dpi:unscaled,
        /usr/X11R6/lib/X11/fonts/misc:unscaled,
        /usr/X11R6/lib/X11/fonts/misc,
        /usr/X11R6/lib/X11/fonts/Speedo,
        /usr/X11R6/lib/X11/fonts/TTF,
        /usr/X11R6/lib/X11/fonts/Type1,
        /usr/X11R6/lib/X11/fonts/hanyang,
        /usr/share/fonts/default/Type1,
        /usr/share/fonts/ko/saemmul,
        /usr/share/fonts/hanyang

If nobody objects, I'll create a patch to do this, and commit to CVS.
Comment 1 Adam Jackson 2004-12-28 09:09:28 UTC
nobody objects ;)
Comment 2 Eduard Fuchs 2006-01-28 07:52:52 UTC
Created attachment 4492 [details] [review]
this patch change the log output as described in the bug
Comment 3 Dawid Gajownik 2006-02-06 00:07:19 UTC
(In reply to comment #2)
> Created an attachment (id=4492) [edit]

Sorry for the stupid question (I'm just learning programming in C): shouldn't
you use strchr() function instead if index()?
http://www.opengroup.org/onlinepubs/009695399/functions/index.html
Comment 4 Eduard Fuchs 2006-02-09 23:34:19 UTC
(In reply to comment #3)
> Sorry for the stupid question (I'm just learning programming in C): shouldn't
> you use strchr() function instead if index()?
> http://www.opengroup.org/onlinepubs/009695399/functions/index.html

I used the function "index", because this is used also in other functions in 
the file "xf86Config.c".  Functionality is the same.  Which of both is more 
portable, I don't know.
Comment 5 Adam Jackson 2006-04-04 08:01:09 UTC
applied to head and 1.1 branch, thanks!


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.