Bug 2201 - Insufficient robustness in AbortDDX() leaves console locked
Summary: Insufficient robustness in AbortDDX() leaves console locked
Status: RESOLVED DUPLICATE of bug 1933
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: 6.8.1
Hardware: x86 (IA32) Linux (All)
: high critical
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-03 01:35 UTC by Andrew Church
Modified: 2005-01-11 22:34 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch (376 bytes, patch)
2005-01-03 01:36 UTC, Andrew Church
no flags Details | Splinter Review

Description Andrew Church 2005-01-03 01:35:45 UTC
AbortDDX() fails to check whether xf86Info.kbdProc is non-NULL before attempting
to call it.  This can result in a double segfault, leaving the console locked.
Comment 1 Andrew Church 2005-01-03 01:36:44 UTC
Created attachment 1616 [details] [review]
Patch
Comment 2 Alan Coopersmith 2005-01-03 09:40:44 UTC
This was fixed in HEAD already, just needs to be backported to the 6.8.x branch.
The fix in head was commited as:

2004-09-21  Egbert Eich  <eich-at-freedesktop-org>

      * programs/Xserver/hw/xfree86/common/xf86Init.c: (AbortDDX):
	Check if xf86Info.kbdProc pointer is really set before calling
	it on abort as this pointer won't be set if the new modular
	keyboard driver is used (Matthias Hopf).
Comment 3 Roland Mainz 2005-01-12 16:41:04 UTC
Alan Coopersmith wrote:
> This was fixed in HEAD already, just needs to be backported to the 6.8.x 
> branch. The fix in head was commited as:

Alan:
Correct me if I am wrong - the patch has already been applied to the X11R6.8.x
stable branch... right ?
Comment 4 Alan Coopersmith 2005-01-12 17:33:28 UTC
Comment on attachment 1616 [details] [review]
Patch

Whoops - you're right - this was already included in Bug #1933/attachment
#1392 [details] [review].	 Guess I was looking at an out of date copy of the tree when I looked
at this before.  Sorry.
Comment 5 Alan Coopersmith 2005-01-12 17:34:02 UTC

*** This bug has been marked as a duplicate of 1933 ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.