Bug 22564 - Symbol visibility in xserver 1.7: missing symbols for fglrx
Summary: Symbol visibility in xserver 1.7: missing symbols for fglrx
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-30 15:21 UTC by Felix Kuehling
Modified: 2009-06-30 17:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Export symbols needed by the RandR implementation in fglrx (1.19 KB, patch)
2009-06-30 15:21 UTC, Felix Kuehling
no flags Details | Splinter Review

Description Felix Kuehling 2009-06-30 15:21:39 UTC
Created attachment 27277 [details] [review]
Export symbols needed by the RandR implementation in fglrx

GIT change http://cgit.freedesktop.org/xorg/xserver/commit/?id=45c8bd0fe54273039fdaa1eeeafb81b5774f2c75 changed the default symbol visibility of the Xserver. As a result 2 symbols that are needed by the RandR 1.2/1.3 implementation in the fglrx driver are no longer visible:

xf86configptr
xf86CursorScreenKey

We would like to get these two symbols _X_EXPORT'ed before Xserver 1.7 is released. Otherwise it will be problematic for fglrx to support RandR 1.3 on Xserver 1.7.

In the future, we may want to sync our RandR implementation to later versions of the RandR implementation in hw/xfree86/modes. Therefore it would be nice if all symbols used by the Xserver RandR implementation were _X_EXPORT'ed in the future.

Patch is attached, tested on Ubuntu Karmic with a patched version of sarvatt's Xserver 1.6.99.1+git20090627.cabcc1a7-0ubuntu0sarvatt PPA package. nm -D /usr/bin/Xorg confirms that the two symbols above are now exported.
Comment 1 Alex Deucher 2009-06-30 17:09:35 UTC
committed: 3525d140567e0ad5f0184e4b37893c47239e1628


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.