Created attachment 27301 [details] [review]
cross compilation fixes
While some changes have been to libX11 made to fix cross compilation, there are still things missing.
First, while CC has been replaced by CC_FOR_BUILD, CPPFLAGS, CFLAGS and LDFLAGS are still used. These should be replaced by CPPFLAGS_FOR_BUILD, CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD.
Second, the pkg-config program is used directly rather than using the PKG_CONFIG variable.
Third, pkg-config's PKG_CONFIG_SYSROOT_DIR is not used.
The attached patch fixes these three issues.
The portions of the patch for the first two issues were updated to
apply to the libX11 1.3.x branch and included for the libX11-1.3.4
The reviewers dicsussing this on IRC weren't sure about the
PKG_CONFIG_SYSROOT_DIR changes, so those were left out for
now - they can be added later if you can explain why they're
I think this is fixed. Please send a patch to firstname.lastname@example.org if it is not. Putting patches on bugzilla is a great way for them to get lost.