Bug 22584 - libX11 does not cross compile
Summary: libX11 does not cross compile
Alias: None
Product: xorg
Classification: Unclassified
Component: Lib/Xlib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2009-07-01 09:52 UTC by Paul Bender
Modified: 2010-12-03 16:39 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

cross compilation fixes (1.93 KB, patch)
2009-07-01 09:52 UTC, Paul Bender
no flags Details | Splinter Review

Description Paul Bender 2009-07-01 09:52:26 UTC
Created attachment 27301 [details] [review]
cross compilation fixes

While some changes have been to libX11 made to fix cross compilation, there are still things missing.

First, while CC has been replaced by CC_FOR_BUILD, CPPFLAGS, CFLAGS and LDFLAGS are still used. These should be replaced by CPPFLAGS_FOR_BUILD, CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD.

Second, the pkg-config program is used directly rather than using the PKG_CONFIG variable.

Third, pkg-config's PKG_CONFIG_SYSROOT_DIR is not used.

The attached patch fixes these three issues.
Comment 1 Alan Coopersmith 2010-06-03 17:09:31 UTC
The portions of the patch for the first two issues were updated to
apply to the libX11 1.3.x branch and included for the libX11-1.3.4

The reviewers dicsussing this on IRC weren't sure about the 
PKG_CONFIG_SYSROOT_DIR changes, so those were left out for
now - they can be added later if you can explain why they're
Comment 2 Matt Turner 2010-12-03 16:39:47 UTC
I think this is fixed. Please send a patch to xorg-devel@lists.x.org if it is not. Putting patches on bugzilla is a great way for them to get lost.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.