Bug 2286 - Duplicate compose entries
Summary: Duplicate compose entries
Status: CLOSED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: * Other (show other bugs)
Version: 6.8.2
Hardware: All Linux (All)
: high normal
Assignee: Daniel Stone
QA Contact:
URL:
Whiteboard:
Keywords:
: 8587 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-01-15 11:23 UTC by Stefan Dirsch
Modified: 2011-10-15 16:23 UTC (History)
9 users (show)

See Also:
i915 platform:
i915 features:


Attachments
Duplicate compose entries (4.64 KB, text/plain)
2005-01-17 04:12 UTC, Andreas Schwab
no flags Details
removes duplicate entries from Compose files (10.29 KB, patch)
2006-10-18 06:43 UTC, Benno Schulenberg
no flags Details | Splinter Review
removes the entries that get redefined (15.30 KB, patch)
2006-10-18 06:44 UTC, Benno Schulenberg
no flags Details | Splinter Review
remove the four-keys that interfere with three-keys (21.07 KB, patch)
2006-10-18 06:45 UTC, Benno Schulenberg
no flags Details | Splinter Review

Description Stefan Dirsch 2005-01-15 11:23:14 UTC
The X11 compose tables contain many duplicate entries.  Eg. in en_US.UTF-8:   
   
<Multi_key> <C> <slash>                 : "?" U20a1 # COLON SIGN   
<Multi_key> <C> <slash>                 : "ยข" U00A2 # CENT SIGN   
  
The second entry overrides the first one. 
 
* How to reproduce:  
 
$ cd /usr/X11R6/lib/X11/locale  
$ for f in */Compose; do  
  echo $f:  
  sed -e '/^#/d' -e 's/[[:space:]]*#.*//' -e '/[^[:space:]]/!d' \  
      -e 's/^[[:space:]]*//' -e 's/[[:space:]]*:.*//' \  
      -e 's/[[:space:]]\+/ /g' $f | sort | uniq -d  
done
Comment 1 Egbert Eich 2005-01-17 03:08:38 UTC
People seemed to have added stuff without checking that a sequence has already
been taken.
Maybe we should take out the entries that are no longer used.
With your script could you please create a nicely formatted list of douplicates
sorted by the files they are in and attach it?
Comment 2 Stefan Dirsch 2005-01-17 03:32:51 UTC
Andreas, could you please take care of this? Thanks. 
Comment 3 Andreas Schwab 2005-01-17 04:12:02 UTC
Created attachment 1691 [details]
Duplicate compose entries
Comment 4 Erik Andren 2006-04-18 00:19:17 UTC
Has anything been done to remove these duplicate entries bast on the attached list?
Comment 5 Daniel Stone 2006-04-18 00:28:28 UTC
that's just a list of the duplicate entries.  someone needs to work out a patch
that actually removes them and gives us the most sensible list.
Comment 6 Benno Schulenberg 2006-10-18 06:43:46 UTC
Created attachment 7455 [details] [review]
removes duplicate entries from Compose files


The first patch removes duplicates from the Compose files (lines identical 
to others), the second patch removes the ones that are overridden by later
combinations, and the third patch comments out or removes the four-key 
sequences that interfere with three-key sequences.

The first patch also does a little reordering (with <dead_abovedot>,
<dead_abovering>, and <dead_ogonek>), the second patch also repairs a typo
(<dead_caron> <c>), and the third patch also adds an alternative for ubreve, 
and replaces service mark and trade mark with shorter alternatives.
Comment 7 Benno Schulenberg 2006-10-18 06:44:43 UTC
Created attachment 7456 [details] [review]
removes the entries that get redefined
Comment 8 Benno Schulenberg 2006-10-18 06:45:46 UTC
Created attachment 7457 [details] [review]
remove the four-keys that interfere with three-keys

This also solves bug #8587.
Comment 9 Daniel Stone 2006-10-28 17:10:48 UTC
pushed the fix to master, thanks
Comment 10 Daniel Stone 2006-10-28 17:11:01 UTC
*** Bug 8587 has been marked as a duplicate of this bug. ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.