Bug 23378 - Unportable test(1) constructs in various places
Summary: Unportable test(1) constructs in various places
Status: RESOLVED FIXED
Alias: None
Product: Farstream
Classification: Unclassified
Component: Core (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) NetBSD
: medium normal
Assignee: Olivier Crête
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-17 13:54 UTC by Thomas Klausner
Modified: 2013-03-22 19:19 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Thomas Klausner 2009-08-17 13:54:26 UTC 
The configure script and various Makefiles contain the  unportable bash "==" comparison operator for test(1). It is not supported by most other shells or even test(1) from GNU coreutils. Please use "=" instead.

Occurrences are in configure (if test "x$ERROR_CFLAGS" == "x"), common/glib-gen.mak, common-modified/glib-gen.mak (@if test "x$(glib_enum_headers)" == "x"; then echo "ERROR: glib_enum_headers is empty, please fix Makefile"; exit 1; fi) and all Makefiles that include it.
Comment 1 Olivier Crête 2009-08-17 14:04:32 UTC 
fix in both common/ (which is in gstreamer) and common-modified (which is part of fs2)
Comment 2 Thomas Klausner 2009-10-30 19:45:40 UTC 
Two occurrences left in common/glib-gen.mak (@if test "x$(glib_enum_headers)" == "x"; then echo "ERROR: glib_enum_headers is empty, please fix Makefile"; exit 1; fi) and configure (if test "x$ERROR_CFLAGS" == "x") in farsight2-0.0.16.
Comment 3 Olivier Crête 2013-03-22 19:19:30 UTC 
I believe this is fixed now

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.