Bug 23582 - PK 0.9x does not trim list of exported symbols
Summary: PK 0.9x does not trim list of exported symbols
Status: RESOLVED FIXED
Alias: None
Product: PolicyKit
Classification: Unclassified
Component: libpolkit (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact: David Zeuthen (not reading bugmail)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-28 13:23 UTC by Michael Biebl
Modified: 2009-09-13 10:48 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
list of exported symbols (16.87 KB, text/plain)
2009-08-28 13:23 UTC, Michael Biebl
Details
list of exported symbols which are not part of the public API (9.59 KB, text/plain)
2009-08-28 15:22 UTC, Michael Biebl
Details
0001-Trim-the-list-of-exported-symbols (1.78 KB, patch)
2009-08-31 09:37 UTC, Michael Biebl
Details | Splinter Review
0002-Use-_polkit_agent_marshal-prefix (2.47 KB, patch)
2009-08-31 09:38 UTC, Michael Biebl
Details | Splinter Review
0003-Make-private-symbols-accessible-to-libpolkitagent-and libpolkitbackend (3.70 KB, patch)
2009-08-31 09:38 UTC, Michael Biebl
Details | Splinter Review

Description Michael Biebl 2009-08-28 13:23:33 UTC
Created attachment 28988 [details]
list of exported symbols

As you can see from the attached file, the libpolkit* libs export symbols which are not part of the public API.
This is most likely due to a missing export-symbols file (or regex)
Comment 1 Michael Biebl 2009-08-28 15:22:12 UTC
Created attachment 28993 [details]
list of exported symbols which are not part of the public API

Attached is the list of export symbols, which is not part of the public API (i.e. /usr/include/polkit-1/)
Comment 2 Michael Biebl 2009-08-31 09:37:51 UTC
Created attachment 29043 [details] [review]
0001-Trim-the-list-of-exported-symbols
Comment 3 Michael Biebl 2009-08-31 09:38:13 UTC
Created attachment 29044 [details] [review]
0002-Use-_polkit_agent_marshal-prefix
Comment 4 Michael Biebl 2009-08-31 09:38:45 UTC
Created attachment 29045 [details] [review]
0003-Make-private-symbols-accessible-to-libpolkitagent-and libpolkitbackend
Comment 5 Michael Biebl 2009-08-31 19:33:00 UTC
I tested the patches briefly and everythings seems to work fine so far.
The only problem I ecountered is, that when I run polkit-gnome-authentication-agent-1, I get the following output on stdout:

(polkit-gnome-authentication-agent-1:21185): GLib-GObject-WARNING **: cannot register existing type `_PolkitError'                                                                                                           
(polkit-gnome-authentication-agent-1:21185): GLib-CRITICAL **: g_once_init_leave: assertion `initialization_value != 0' failed  


There are also other warnings like
(polkit-gnome-authentication-agent-1:5656): GLib-GIO-WARNING **: g_simple_async_result_complete() called from outside main loop!
but they were also there before the patches.
Comment 6 David Zeuthen (not reading bugmail) 2009-09-13 10:48:06 UTC
Applied, thanks. I'll look into the warning for _PolkitError - the one about the main loop should be fixed in the next GLib release, see

 http://bugzilla.gnome.org/show_bug.cgi?id=594148


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.