Bug 23733 - 64-bit cairomm build error because of 32-bit only cairo function
Summary: 64-bit cairomm build error because of 32-bit only cairo function
Status: RESOLVED FIXED
Alias: None
Product: cairomm
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Mac OS X (All)
: medium normal
Assignee: Murray Cumming
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-05 14:49 UTC by Augusto Jun Devegili
Modified: 2010-06-07 01:00 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Fix build error on x86_64 (1.83 KB, patch)
2009-09-05 14:49 UTC, Augusto Jun Devegili
Details | Splinter Review

Description Augusto Jun Devegili 2009-09-05 14:49:06 UTC
Created attachment 29257 [details] [review]
Fix build error on x86_64

This refers to cairomm version 1.8.2 (wasn't listed in bug report page).

cairo 1.8.8 limits cairo_public cairo_font_face_t *cairo_quartz_font_face_create_for_atsu_font_id (ATSUFontID font_id) to 32-bit only (src/cairo-quartz.h, src/cairo-quartz-font.c). However, cairomm 1.8.2, cairomm/quartz_font.h, cairomm/quartz_font.cc provide methods that end up calling that aforementioned 32-bit only function, causing a build error on x86_64:

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -I/sw64/lib/fontconfig2/include -I/sw64/include/cairo -I/sw64/include/pixman-1 -I/sw64/include/freetype2 -I/sw64/include -I/sw64/include/libpng12 -I/sw64/include/sigc++-2.0 -I/sw64/lib/sigc++-2.0/include -I/usr/X11R6/include -I/usr/X11/include -I/sw64/lib/fontconfig2/include -DENABLE_GCC_VISIBILITY=1 -I/sw64/include -g -O2 -c quartz_font.cc  -fno-common -DPIC -o .libs/quartz_font.o
quartz_font.cc: In constructor 'Cairo::QuartzFontFace::QuartzFontFace(ATSUFontID)':
quartz_font.cc:34: error: 'cairo_quartz_font_face_create_for_atsu_font_id' was not declared in this scope
make[3]: *** [quartz_font.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1
### execution of make failed, exit code 2

The attached patch is an attempt to fix that.

Build Date & Platform:
2009-09-05 on Mac OS X 10.5.8 (64-bit Fink)
Comment 1 Murray Cumming 2010-06-07 01:00:32 UTC
Thanks. Yes, that's what cairo does so it's the correct fix in cairomm too.

I have pushed your patch to cairomm's git master. Many thanks and sorry for the delay.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.