This is a follow up of bug #4102. Nicolas suggested using "nbsp" feature list for optional mapping of ZWNJ and ZWJ on <SPCE>, as they are used in at least 5 layouts.
Before attaching the patch, I should note that there is an alternate solution, making a option group for ZWNJ/ZNJ. Pros are:
- Non-Arabic user don't bother about the whole group
- There will be no need to change the title of "nbsp" group
Also, I noticed we have a mixture of American and British spellings in base.xml, ie. Behavior and Behaviour. Should we bother fixing these?
Created attachment 29639 [details] [review]
[PATCH] Add ZWNJ/ZWJ parts to nbsp group
- Add 8 options for ZWNJ and ZWJ on space key to nbsp group
- Use the partial layouts in af, in, ir, lk, sy
rules/base.xml.in | 50 ++++++++++++++++++++-
symbols/af | 15 ++++---
symbols/in | 5 +-
symbols/ir | 26 +++++-----
symbols/lk | 2 +-
symbols/nbsp | 130 +++++++++++++++++++++++++++++++++++++++++++++++++---
symbols/sy | 3 +-
7 files changed, 199 insertions(+), 32 deletions(-)
Thanks, that's fine. Committed.