Bug 23995 (ZWJ) - Add ZWNJ/ZNJ mappingson SPCE to "nbsp" feature list
Summary: Add ZWNJ/ZNJ mappingson SPCE to "nbsp" feature list
Alias: ZWJ
Product: xkeyboard-config
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: xkb
QA Contact:
Depends on:
Blocks: Persian
  Show dependency treegraph
Reported: 2009-09-17 07:32 UTC by Behnam Esfahbod [:zwnj]
Modified: 2010-01-28 16:45 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

[PATCH] Add ZWNJ/ZWJ parts to nbsp group (15.03 KB, patch)
2009-09-17 08:35 UTC, Behnam Esfahbod [:zwnj]
Details | Splinter Review

Description Behnam Esfahbod [:zwnj] 2009-09-17 07:32:36 UTC
This is a follow up of bug #4102.  Nicolas suggested using "nbsp" feature list for optional mapping of ZWNJ and ZWJ on <SPCE>, as they are used in at least 5 layouts.
Comment 1 Behnam Esfahbod [:zwnj] 2009-09-17 08:17:32 UTC
Before attaching the patch, I should note that there is an alternate solution, making a option group for ZWNJ/ZNJ.  Pros are:
- Non-Arabic user don't bother about the whole group
- There will be no need to change the title of "nbsp" group

Also, I noticed we have a mixture of American and British spellings in base.xml, ie. Behavior and Behaviour.  Should we bother fixing these?
Comment 2 Behnam Esfahbod [:zwnj] 2009-09-17 08:35:56 UTC
Created attachment 29639 [details] [review]
[PATCH] Add ZWNJ/ZWJ parts to nbsp group

- Add 8 options for ZWNJ and ZWJ on space key to nbsp group
- Use the partial layouts in af, in, ir, lk, sy
 rules/base.xml.in |   50 ++++++++++++++++++++-
 symbols/af        |   15 ++++---
 symbols/in        |    5 +-
 symbols/ir        |   26 +++++-----
 symbols/lk        |    2 +-
 symbols/nbsp      |  130 +++++++++++++++++++++++++++++++++++++++++++++++++---
 symbols/sy        |    3 +-
 7 files changed, 199 insertions(+), 32 deletions(-)
Comment 3 Sergey V. Udaltsov 2010-01-28 16:45:34 UTC
Thanks, that's fine. Committed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.