Bug 2410 - xrx build broken on systems without shared libs
Summary: xrx build broken on systems without shared libs
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: App/other (show other bugs)
Version: 6.8.2
Hardware: Other OpenBSD
: high normal
Assignee: Roland Mainz
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-28 14:47 UTC by Matthieu Herrb
Modified: 2005-01-31 01:09 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
end of log of broken build on OpenBSD/vax (1.84 KB, text/plain)
2005-01-28 14:48 UTC, Matthieu Herrb 		no flags Details
[FIXED_X11R68x] proposed patch (510 bytes, patch)
2005-01-28 16:02 UTC, Matthieu Herrb 		roland.mainz: 6.8-branch+
Details | Splinter Review
Patch for 2005-02-01-trunk and X11R6.8.x stable branch including the requested comment (3.15 KB, patch)
2005-01-31 20:01 UTC, Roland Mainz 		no flags Details | Splinter Review
Show Obsolete (1) View All

Description Matthieu Herrb 2005-01-28 14:47:07 UTC 
the xrx code that was re-enabled between RC2 and RC3 has not been tested on
systems with HasSharedLibs = NO. 
See attached build log on OpenBSD/vax.
Comment 1 Matthieu Herrb 2005-01-28 14:48:59 UTC 
Created attachment 1780 [details]
end of log of broken build on OpenBSD/vax
Comment 2 Matthieu Herrb 2005-01-28 16:02:48 UTC 
Created attachment 1782 [details] [review]
[FIXED_X11R68x] proposed patch
Comment 3 Roland Mainz 2005-01-31 19:36:33 UTC 
Comment on attachment 1782 [details] [review]
[FIXED_X11R68x] proposed patch

Approved for commit into X11R6.8.x stable branch in the 2005-01-31 Xorg
release-wranglers phone call.
Please do not commit yourself, I'll do that myself in a few mins...

(One nit: As outlined in the call there should be a comment why
|HasSharedLibraries| needs to be used (I'll handle that, too)).
Comment 4 Roland Mainz 2005-01-31 20:01:38 UTC 
Created attachment 1807 [details] [review]
Patch for 2005-02-01-trunk and X11R6.8.x stable branch including the requested comment

Taking bug for commit...
Comment 5 Roland Mainz 2005-01-31 20:06:45 UTC 
Comment on attachment 1807 [details] [review]
Patch for 2005-02-01-trunk and X11R6.8.x stable branch including the requested comment

Patch checked-in into Xorg trunk:

/cvs/xorg/xc/ChangeLog,v  <--  xc/ChangeLog
new revision: 1.736; previous revision: 1.735
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/config/cf/X11.tmpl,v  <--	xc/config/cf/X11.tmpl
new revision: 1.41; previous revision: 1.40
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 6 Roland Mainz 2005-01-31 20:08:24 UTC 
Comment on attachment 1807 [details] [review]
Patch for 2005-02-01-trunk and X11R6.8.x stable branch including the requested comment

Patch checked-in into X11R6.8.x stable branch...

/cvs/xorg/xc/ChangeLog,v  <--  xc/ChangeLog
new revision: 1.365.2.141; previous revision: 1.365.2.140
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/config/cf/X11.tmpl,v  <--	xc/config/cf/X11.tmpl
new revision: 1.35.2.3; previous revision: 1.35.2.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...
Comment 7 Roland Mainz 2005-01-31 20:09:46 UTC 
Patch checked-in into Xorg trunk and X11R6.8.x stable branch...

... marking bug as FIXED.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.