Bug 24236 - crashed with NameError in __group_contact_delete_errback()
Summary: crashed with NameError in __group_contact_delete_errback()
Status: RESOLVED FIXED
Alias: None
Product: papyon
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Louis-Francis Ratté-Boulianne
QA Contact: Telepathy bugs list
URL: https://bugs.launchpad.net/ubuntu/+so...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2009-09-30 15:40 UTC by Olivier Le Thanh Duong
Modified: 2009-10-08 18:28 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Olivier Le Thanh Duong 2009-09-30 15:40:13 UTC 
Transfered from launchpad

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/papyon/service/SOAPService.py", line 223, in _response_handler
    user_data)
  File "/usr/lib/pymodules/python2.6/papyon/service/AddressBook/ab.py", line 362, in _HandleSOAPFault
    errback[0](errcode, *errback[1:])
  File "/usr/lib/pymodules/python2.6/papyon/service/AddressBook/scenario/groups/group_contact_delete.py", line 48, in __group_contact_delete_errback
    errcode = AddressBookError.UNKNOWN
NameError: global name 'AddressBookError' is not defined
Comment 1 Olivier Le Thanh Duong 2009-09-30 15:52:35 UTC 
We were missing an import, branch to fix this :
http://git.collabora.co.uk/?p=user/olethanh/papyon.git;a=shortlog;h=refs/heads/fix_24236
Comment 2 Simon McVittie 2009-10-06 05:34:57 UTC 
> +from papyon.service.AddressBook.constants import *

Ugh. Isn't "from foo import *" generally considered harmful?

(It makes it hard to determine where your symbols came from...)
Comment 3 Olivier Le Thanh Duong 2009-10-08 16:37:45 UTC 
Tbh I simply copied how it was done in the others modules, but you are right, I will correct it.
Comment 4 Olivier Le Thanh Duong 2009-10-08 18:28:05 UTC 
Corrected and merged

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.