This enhancement targets the configuration and infrastructure of the component, as provided by the Autotools artifacts. It does not involve any object code changes or any functional behavior changes. Some global maintenance items are also applied which have been reviewed in the following bug reports, or are part of the modules guidelines (http://wiki.x.org/wiki/NewModuleGuidelines): 24206: Several INSTALL, NEWS, README and AUTHORS files are missing/incorrect 24238: Several components do not specify AM_MAINTAINER_MODE 24239: .gitignore enhancement: common template with default values for components In AC_INIT first param is the 'package name' rather than the 'tar file name'. Most components have the 4 params version where first and fourth are the same. I have attempted to provide a friendly package name: AC_INIT([X.Org Macros], Taking a chance here... The package name is used in numerous places, such as help: "`configure' configures X.Org Macros 1.3.1 to adapt to many kinds of systems." and in config.log: "It was created by X.Org Macros configure 1.3.1, which was.."
Created attachment 30260 [details] [review] [PATCH] configuration: update, fix warnings, apply global maintenance
Created attachment 30261 [details] [review] [PATCH] .gitignore: use common defaults with custom section
Created attachment 30262 [details] [review] [PATCH] INSTALL file missing/incorrect Additional patches will follow to allow other components to obtain a copy of the INSTALL file as per 24206.
Created attachment 30264 [details] [review] Add an XORG_INSTALL macro to allow comps to copy the INSTALL file #24206 Could you check the quoting in INSTALL_CMD? It works, but...
Created attachment 30265 [details] [review] [PATCH] Remove a comment about a workaround in XORG_CHANGELOG macro I forgot to remove the comment about the distcleancheck workaround, so it will be very confusing in the future. This is the last intended patch. The first 3 are about the macros component being changed like any other component component would. The important last one (attach 30264) is the mechanism by which other components will get a copy of the INSTALL file.
Created attachment 30290 [details] [review] [PATCH] configuration: update, fix warnings, apply global maintenance I had to redo the patches. See also 24278. The patch for XORG_INSTALL moved to 24206.
Created attachment 30291 [details] [review] [PATCH] .gitignore: use common defaults with custom section
Created attachment 30292 [details] [review] [PATCH] INSTALL file missing/incorrect
Commits: ceecddadf923ceae76c12057103ec7a409718a34 e6ceec1bc497ce9d311fd17e9a171e83148362ad 22d7360510553775650e6a4e134f165937db4abe bf44a8df3831ac465fd79937b059e54c4dc34486 98c7586b04dea14d89df6e7ad1c733e6539cd095 b47a30d3c91fbd5b230a11b1a5ddbfb943bcd7b2 f8695cf7b892028bf7c502e85f26f0a756edd316 Had to lower AC_PREREQ from 2.63 to 2.60 as tinderbox failed. Not sure what level it has, but other modules are at 2.60. At the time I checked for this, I had seen modules at 2.63 and even 2.64, but not anymore. I checked the best I could and there seems to be no important differences between 2.60 and 2.63 for us.
(In reply to comment #9) > Commits: > > ceecddadf923ceae76c12057103ec7a409718a34 > e6ceec1bc497ce9d311fd17e9a171e83148362ad > 22d7360510553775650e6a4e134f165937db4abe > bf44a8df3831ac465fd79937b059e54c4dc34486 > 98c7586b04dea14d89df6e7ad1c733e6539cd095 > b47a30d3c91fbd5b230a11b1a5ddbfb943bcd7b2 > f8695cf7b892028bf7c502e85f26f0a756edd316 > > Had to lower AC_PREREQ from 2.63 to 2.60 as tinderbox failed. Not sure what > level it has, but other modules are at 2.60. At the time I checked for this, I > had seen modules at 2.63 and even 2.64, but not anymore. > > I checked the best I could and there seems to be no important differences > between 2.60 and 2.63 for us. > I figured out the effective minimum version for autoconf is 2.60. On a separate computer I downloaded several versions and alternated between them. Below 2.60, there are problems. Version 2.57 dates back 2002. Version 2.60 has significant changes like directories definitions. Tinderbox has at least 2.60. It was released in 2006. I'll update the AC_PREREQ statements so it will serve a s documentation.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.