Bug 24606 - Does not support reiserfs (v3) as known file system
Summary: Does not support reiserfs (v3) as known file system
Status: RESOLVED FIXED
Alias: None
Product: udisks
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: David Zeuthen (not reading bugmail)
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-18 11:36 UTC by Michael Biebl
Modified: 2009-12-04 06:06 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
ReiserFS support patch for DK-disks (4.84 KB, patch)
2009-11-05 18:30 UTC, Michael Biebl 		Details | Splinter Review
ReiserFS support patch for gnome-disk-utility (1.49 KB, patch)
2009-11-05 18:31 UTC, Michael Biebl 		Details | Splinter Review
ReiserFS support patch for udisks (4.02 KB, patch)
2009-12-03 15:47 UTC, Michael Biebl 		Details | Splinter Review
Show Obsolete (2) View All

Description Michael Biebl 2009-10-18 11:36:47 UTC 
reiserfs is not listed in known_file_systems and as such has also no support in job-mkfs and job-change-filesystem-label.

As reiserfs (v3) is still a commonly used file system and a lot of distros still allow to create reiserfs partitions during install so support for it in DK-disks would be nice.
Comment 1 Michael Biebl 2009-11-05 18:30:53 UTC 
Created attachment 31004 [details] [review]
ReiserFS support patch for DK-disks
Comment 2 Michael Biebl 2009-11-05 18:31:23 UTC 
Created attachment 31005 [details] [review]
ReiserFS support patch for gnome-disk-utility
Comment 3 Martin Pitt 2009-11-11 06:35:41 UTC 
I updated my test suite to check reiserfs, too, and it passes:

fs: reiserfs ... [cli] [dkd] ok

If you don't have reiserfsprogs installed, it just skips:

fs: reiserfs ... [no mkfs.reiserfs, skip] ok

As with the other FSes, this checks create/open files/relabel/mount/umount/take ownership/KnownFilesystems/presentation name, so it looks complete to me.
Comment 4 Michael Biebl 2009-12-03 15:47:45 UTC 
Created attachment 31715 [details] [review]
ReiserFS support patch for udisks
Comment 5 David Zeuthen (not reading bugmail) 2009-12-04 06:06:41 UTC 
Committed with one change: Please use a — instead of - in the subject when separating the bug number and the subject. Thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.