Bug 24620 - Add a KDE4 applet
Summary: Add a KDE4 applet
Status: RESOLVED FIXED
Alias: None
Product: UIM
Classification: Unclassified
Component: helper: toolbar (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: uim-bugs
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-19 06:59 UTC by Muneyuki Noguchi
Modified: 2009-10-25 11:27 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
patch to add a plasmoid (12.12 KB, patch)
2009-10-19 06:59 UTC, Muneyuki Noguchi
Details | Splinter Review

Description Muneyuki Noguchi 2009-10-19 06:59:56 UTC
Created attachment 30552 [details] [review]
patch to add a plasmoid

The attached patch adds `--enable-kde4-applet' option to ./configure. Since the KDE project switched from Autotools to CMake, CMake is required to build a KDE4 applet, a.k.a. plasmoid.

Notes:
- A menu on a tool button and a context menu appear at an incorrect position
  in this plasmoid.

  I suspect this nasty issue is relevant to this bug in Qt:
    249306 - QToolButton popup menu is shown at wrong position when embedded
    in a QGraphicsView
    http://qt.nokia.com/developer/task-tracker/index_html?method=entry&id=249306

  (Plasma::PopupApplet inherits Plasma::Applet and Plasma::Applet inherits
  QGraphicsProxyWidget)

- qt4/toolbar/build/.svnignore is just a dummy file. I've added this file
  because `svn diff' can't handle an empty directory. AFAIK, unlike CVS or git, 
  Subversion can add an empty directory. So you can remove this .svnignore
  as far as you use Subversion.
Comment 1 Etsushi Kato 2009-10-25 11:27:30 UTC
(In reply to comment #0)
> Created an attachment (id=30552) [details]
> patch to add a plasmoid

Thanks!  I've committed it in r6038 with some modification noted below.  Please let me know if you find any problem.


> The attached patch adds `--enable-kde4-applet' option to ./configure. Since the
> KDE project switched from Autotools to CMake, CMake is required to build a KDE4
> applet, a.k.a. plasmoid.

Since ./configure can't go through on system without kde4 and/or cmake, I modified it to use AC_MSG_WARN, and set use_apple_kde4="no".

> - qt4/toolbar/build/.svnignore is just a dummy file. I've added this file
>   because `svn diff' can't handle an empty directory. AFAIK, unlike CVS or git, 
>   Subversion can add an empty directory. So you can remove this .svnignore
>   as far as you use Subversion.
 
I didn't add qt4/toolbar/build directory.  Instead, ensure ./configure to create the directory since empty directory cannot cope with 'make dist'.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.