Bug 24646 - [i965] piglit arl.vpfp fails
Summary: [i965] piglit arl.vpfp fails
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/i965 (show other bugs)
Version: 7.6
Hardware: All All
: medium normal
Assignee: Ian Romanick
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 21786
  Show dependency tree / graph
 
Reported: 2009-10-20 12:54 UTC by Ian Romanick
Modified: 2009-11-11 14:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments

Description Ian Romanick 2009-10-20 12:54:28 UTC 
The piglit generic VP/FP test arl.vpfp fails with an assertion get_src_reg in brw_vs_emit.c.  While bisecting, either the assertion "assert(c->regs[file][index].nr != 0);" at line 826 or the assertion "assert(0);" at line 844 was hit.  This bisected to the commit listed below.

commit 28b13038d84db1c4e1e56e15d310b30ddffcb7bd
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Wed Jul 22 16:03:32 2009 -0700

    parser: Ensure that param_binding_type is set correctly
Comment 1 Ian Romanick 2009-10-20 12:56:37 UTC 
(In reply to comment #0)

> While bisecting, either the assertion
> "assert(c->regs[file][index].nr != 0);" at line 826 or the assertion
> "assert(0);" at line 844 was hit.

Correction: line 907 for the first assertion, and line 936 for the second.
Comment 2 Ian Romanick 2009-11-11 14:14:19 UTC 
Fixed by (thanks Eric):

commit 23a4a6727efb5c8b2bf84f88f638c15e7255b363
Author: Eric Anholt <eric@anholt.net>
Date:   Tue Nov 10 10:43:19 2009 -0800

    i965: Allow use of PROGRAM_LOCAL constants in ARB_vp.
    
    Fixes piglit arl.vp.
    (cherry picked from commit d52d78b4bcd6d4c0578f972c0b8ebac09e632196)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.