Bug 25015 - Please add application/x-it87_2 to the specification
Summary: Please add application/x-it87_2 to the specification
Status: RESOLVED FIXED
Alias: None
Product: shared-mime-info
Classification: Unclassified
Component: freedesktop.org.xml (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Jonathan Blandford
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-10 06:50 UTC by Richard Hughes
Modified: 2009-11-10 11:02 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
the patch (2.06 KB, patch)
2009-11-10 06:52 UTC, Richard Hughes
Details | Splinter Review
new patch (2.14 KB, patch)
2009-11-10 09:37 UTC, Richard Hughes
Details | Splinter Review
new patch (2.99 KB, patch)
2009-11-10 10:58 UTC, Richard Hughes
Details | Splinter Review

Description Richard Hughes 2009-11-10 06:50:00 UTC
The attached patch adds application/x-it87_2 to the specification which allows gnome-color-manager to associate an icon and allow the user to double click to import it. I'm aware it's matching on *.txt which isn't ideal at all, but the reference data has been generated with this file extension for many many years by big printing houses, and can't really be changed. See http://www.targets.coloraid.de/ for an example.

I'm also aware the test file comes with MSDOS style line endings. This is also how the print houses generate the data, so I left the line endings like they would be with an actual profile.

Please consider. Thanks.
Comment 1 Richard Hughes 2009-11-10 06:52:45 UTC
Created attachment 31089 [details] [review]
the patch
Comment 2 Richard Hughes 2009-11-10 09:37:17 UTC
Created attachment 31094 [details] [review]
new patch

New patch with fixes from hadess.
Comment 3 Bastien Nocera 2009-11-10 09:59:48 UTC
[master e4bde38] Add application/x-it87_2
 3 files changed, 28 insertions(+), 0 deletions(-)
 create mode 100644 tests/test.it872
Comment 4 Richard Hughes 2009-11-10 10:58:20 UTC
Created attachment 31099 [details] [review]
new patch

According to the experts, we should be using x-it87, not x-it872 as the /2 is a revision number, and not a difference in the spec.

Please consider and commit. Thanks. Sorry to muck you around.
Comment 5 Richard Hughes 2009-11-10 10:58:53 UTC
Reopening, as the experts want this more generic.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.