Created attachment 1871 [details] [review]
Patch for 2005-02-09-trunk

Patch checked-in...

/cvs/xorg/xc/ChangeLog,v  <--  xc/ChangeLog
new revision: 1.761; previous revision: 1.760
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
/cvs/xorg/xc/config/cf/gnu.cf,v  <--  xc/config/cf/gnu.cf
new revision: 1.3; previous revision: 1.2
cvs commit: Using deprecated info format strings.  Convert your scripts to use
the new argument format and remove '1's from your info file format strings.
Mailing the commit message to xorg-commit@lists.freedesktop.org...

... marking bug as FIXED.

(In reply to comment #2)
> ... marking bug as FIXED.

There are other issues when building xprint-xprintorg with that patch:

a)

gcc -c -O2 -fno-strength-reduce -fno-strict-aliasing  -ansi -pedantic -Wall
-Wpointer-arith -Wstrict-prot
otypes                    -Wmissing-prototypes -Wmissing-declarations          
          -Wredundant-dec
ls -Wnested-externs -Wundef    -I../.. -I../../exports/include   -D__i386__
-D_POSIX_C_SOURCE=199309L    
                           -D_POSIX_SOURCE -D_XOPEN_SOURCE                     
         -D_BSD_SOURCE -D
_SVID_SOURCE  -DFUNCPROTO=15 -DNARROWPROTO -DXTHREADS  -D_REENTRANT
-DXUSE_MTSAFE_API       AuGetBest.c
In file included from /usr/include/pthread/pthread.h:33,
                 from /usr/include/pthread.h:2,
                 from ../../exports/include/X11/Xthreads.h:232,
                 from AuGetBest.c:33:
/usr/include/bits/pthread.h:27: error: syntax error before "int"

This one is due to the Hurd libphread headers using a code construct which is 
not valid when compiling using -ansi, as is the case here.

This bug has been fixed upstream and the patch will be in the next version of
the Debian hurd package, so no worry.

b)

gcc -c -O2 -fno-strength-reduce -fno-strict-aliasing  -ansi -pedantic -Wall
-Wpointer-arith -Wstrict-prot
otypes                    -Wmissing-prototypes -Wmissing-declarations          
          -Wredundant-dec
ls -Wnested-externs -Wundef    -I../.. -I../../exports/include   -D__i386__
-D_POSIX_C_SOURCE=199309L    
                           -D_POSIX_SOURCE -D_XOPEN_SOURCE                     
         -D_BSD_SOURCE -D
_SVID_SOURCE  -DFUNCPROTO=15 -DNARROWPROTO -DXTHREADS  -D_REENTRANT
-DXUSE_MTSAFE_API    -DMALLOC_0_RETUR
NS_NULL     -fPIC XpJob.c
XpJob.c: In function `XpStartJob':
XpJob.c:108: error: too few arguments to function `getpwuid_r'
make[5]: *** [XpJob.o] Error 1

Not sure about that one, I need to investigate further.


c)

gcc -c -O2 -fno-strength-reduce -fno-strict-aliasing  -ansi -pedantic -Wall
-Wpointer-arith -Wstrict-prot
otypes                    -Wmissing-prototypes -Wmissing-declarations          
          -Wredundant-dec
ls -Wnested-externs -Wundef  -I../../../include/fonts -I../include
-I../../../lib/xtrans  -I../../.. -I..
/../../exports/include   -D__i386__ -D_POSIX_C_SOURCE=199309L                  
            -D_POSIX_SOUR
CE -D_XOPEN_SOURCE                               -D_BSD_SOURCE -D_SVID_SOURCE 
-DFUNCPROTO=15 -DNARROWPRO
TO    -DUNIXCONN -DTCPCONN -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN -DIPv6 -DFONT_t
-DTRANS_CLIENT -DTRANS_SERVE
R -DTRANS_REOPEN -DBSD44SOCKETS   transport.c
In file included from transport.c:80:
../../../lib/xtrans/Xtranssock.c:1392: error: `MAXHOSTNAMELEN' undeclared here
(not in a function)
make[6]: *** [transport.o] Error 1


This is due to struct addrlist in Xtranssock.c declaring MAXHOSTNAMELEN without
checking whether this is actually defined. POSIX only mandates that
MAXHOSTNAMELEN be defined to the  maximum hostname length if a limitation
exists, which is not the case for GNU and thus this is undefined on GNU. We will
try to come up with a patch for this, if you do not have a clear view on how to
fix this yourself.


Thanks,

Michael Banck