Bug 25116 - CreateChannel MUST include TargetID in return value.
Summary: CreateChannel MUST include TargetID in return value.
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-python (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
Depends on:
Reported: 2009-11-16 04:32 UTC by David Laban
Modified: 2009-12-11 03:45 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description David Laban 2009-11-16 04:32:21 UTC
I was hacking around with the echo bot+butterfly, and found that TargetID was missing from the properties returned when I requested a StreamedMedia channel. I think this is where it's happening, but I was supposed to be working on tp-glib bugs, so this was as far as I got.

diff --git a/src/server/conn.py b/src/server/conn.py
index 0ef2206..7e933d6 100644
--- a/src/server/conn.py
+++ b/src/server/conn.py
@@ -520,6 +520,9 @@ class ConnectionInterfaceRequests(
         for p in todel:
             del props[p]
+        # http://telepathy.freedesktop.org/spec/org.freedesktop.Telepathy.Connection.Interface.Requests.html
+        # says that we MUST include ChannelType, TargetHandleType, TargetHandle, TargetID, and Requested.
+        # We currently strip out TargetID. This is bad.
         _success(channel._object_path, props)
         # CreateChannel MUST return *before* NewChannels is emitted.
Comment 1 Olivier Le Thanh Duong 2009-12-11 03:45:05 UTC
Fixed in master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.