Bug 25334 - mismatch in spelling quirk.vga_mode3 vs halinfo (and standard)
Summary: mismatch in spelling quirk.vga_mode3 vs halinfo (and standard)
Status: RESOLVED FIXED
Alias: None
Product: pm-utils
Classification: Unclassified
Component: General (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Victor Lowther
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-28 11:05 UTC by Tormod Volden
Modified: 2010-02-03 13:27 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
removes the (second) underscore in vga_mode_3 (725 bytes, patch)
2009-11-28 11:06 UTC, Tormod Volden
Details | Splinter Review
corrects the vga-mode-3 typo (1.14 KB, patch)
2009-12-02 15:39 UTC, Tormod Volden
Details | Splinter Review
correct vga-mode3 to vga-mode-3 everywhere (2.87 KB, patch)
2009-12-03 03:45 UTC, Tormod Volden
Details | Splinter Review

Description Tormod Volden 2009-11-28 11:05:41 UTC
99-video-quirk-default.fdi sets power_management.quirk.vga_mode3 but the logic in pm-utils looks for vga_mode_3 (with an extra underscore).

Correcting this might fix a lot of resume issues, and probably make some new...
Comment 1 Tormod Volden 2009-11-28 11:06:47 UTC
Created attachment 31539 [details] [review]
removes the (second) underscore in vga_mode_3
Comment 2 Danny Kukawka 2009-12-02 14:56:37 UTC
I don't see where 99-video-quirk-default.fdi sets vga_mode3 it sets correctly vga_mode_3 as the spec says. 

SPEC:
http://people.freedesktop.org/~dkukawka/hal-spec-git/hal-spec.html

CODE:
http://cgit.freedesktop.org/hal-info/tree/fdi/information/10freedesktop/99-video-quirk-default.fdi

Or do you may have a Dell Inspiron 700m ?
Comment 3 Tormod Volden 2009-12-02 15:19:41 UTC
Sorry, I put it the wrong way in the original description. And I was not sure was the authoritative source is. It is a bug in pm-utils then.

http://cgit.freedesktop.org/pm-utils/tree/pm/sleep.d/99video#n28

		vga-mode3) 	   QUIRK_VGA_MODE_3="true" ;;
should be
		vga-mode-3) 	   QUIRK_VGA_MODE_3="true" ;;
Comment 4 Tormod Volden 2009-12-02 15:39:45 UTC
Created attachment 31687 [details] [review]
corrects the vga-mode-3 typo
Comment 5 Tormod Volden 2009-12-03 03:45:47 UTC
Created attachment 31701 [details] [review]
correct vga-mode3 to vga-mode-3 everywhere
Comment 6 Victor Lowther 2009-12-10 20:00:27 UTC
Thanks for the patch, fixed in next release.
Comment 7 Rafał Miłecki 2010-02-03 13:27:28 UTC
Commited as 7f1732c08db46d76692cb2860c38d5e6d3987cc8
"[PATCH] Fix vga-mode-3 typo in video hooks"


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.