Bug 25339 - segfault unplugging HAL input device
Summary: segfault unplugging HAL input device
Status: RESOLVED DUPLICATE of bug 25374
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/Input/Core (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords:
: 25457 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-11-29 05:45 UTC by Sebastian Glita
Modified: 2009-12-10 09:01 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
fix a bug in Xi/xiproperty.c (635 bytes, patch)
2009-12-06 18:19 UTC, Sebastian Glita
no flags Details | Splinter Review

Description Sebastian Glita 2009-11-29 05:45:36 UTC
Following is a backtrace. Also, doing `xinput remove-master` is not working for some time, a master always showing an "XTEST" device attached...

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ff1dfe82700 (LWP 6281)]
0x000000000051420c in XIDeleteDeviceProperty (device=0x2b7db70, property=247, fromClient=0) at xiproperty.c:645
645             if (prop->propertyName == property)
(gdb) bt
#0  0x000000000051420c in XIDeleteDeviceProperty (device=0x2b7db70, property=247, fromClient=0) at xiproperty.c:645
#1  0x000000000046c984 in DeletePredictableAccelerationProperties (dev=0x2b7db70) at ptrveloc.c:358
#2  0x000000000046c269 in AccelerationDefaultCleanup (dev=0x2b7db70) at ptrveloc.c:134
#3  0x0000000000426a93 in CloseDevice (dev=0x2b7db70) at devices.c:844
#4  0x000000000042700d in RemoveDevice (dev=0x2b7db70, sendevent=1 '\001') at devices.c:993
#5  0x00000000004a19c7 in DeleteInputDeviceRequest (pDev=0x2b7db70) at xf86Xinput.c:671
#6  0x000000000047b2a2 in remove_device (dev=0x2b7db70) at hal.c:72
#7  0x000000000047b3bc in device_removed (ctx=0x2ad6890, udi=0x2ad3ca4 "/org/freedesktop/Hal/devices/usb_device_46d_c517_noserial_if1_logicaldev_input")
    at hal.c:95
#8  0x00007ff1de282f68 in filter_func (connection=0x2ad35e0, message=0x2ad3b00, user_data=0x2ad6890) at libhal.c:1067
#9  0x00007ff1de016b30 in dbus_connection_dispatch (connection=0x2ad35e0)
    at /var/tmp/portage/sys-apps/dbus-1.3.0-r1/work/dbus-1.3.0/dbus/dbus-connection.c:4558
#10 0x00007ff1de01464d in _dbus_connection_read_write_dispatch (connection=0x2ad35e0, timeout_milliseconds=0, dispatch=1)
    at /var/tmp/portage/sys-apps/dbus-1.3.0-r1/work/dbus-1.3.0/dbus/dbus-connection.c:3583
#11 0x00007ff1de014a1b in dbus_connection_read_write_dispatch (connection=0x2ad35e0, timeout_milliseconds=0)
    at /var/tmp/portage/sys-apps/dbus-1.3.0-r1/work/dbus-1.3.0/dbus/dbus-connection.c:3665
#12 0x000000000047ad8c in wakeup_handler (data=0x86f280, err=1, read_mask=0x879340) at dbus-core.c:57
#13 0x000000000043db09 in WakeupHandler (result=1, pReadmask=0x879340) at dixutils.c:403
#14 0x0000000000489814 in WaitForSomething (pClientsReady=0x2ad2590) at WaitFor.c:232
#15 0x000000000045691b in Dispatch () at dispatch.c:381
#16 0x0000000000425048 in main (argc=18, argv=0x7ffff752b9d8, envp=0x7ffff752ba70) at main.c:285
(gdb) q
Comment 1 David Heidelberg (okias) 2009-12-05 01:54:44 UTC
*** Bug 25457 has been marked as a duplicate of this bug. ***
Comment 2 Sebastian Glita 2009-12-06 18:19:57 UTC
Created attachment 31791 [details] [review]
fix a bug in Xi/xiproperty.c

Whereas "->properties.handlers" is assigned `NULL', which indicates it remains alive for future use, "->properties.properties" list should also.
Comment 3 David Heidelberg (okias) 2009-12-07 04:41:42 UTC
Problem FIXED with that patch. Please push it into upstream.
Comment 4 David Heidelberg (okias) 2009-12-08 04:21:42 UTC
Patch still missing in upstream master :-(
Comment 5 Sebastian Glita 2009-12-08 14:48:19 UTC
ok, i'll try
Comment 6 Sebastian Glita 2009-12-10 06:30:43 UTC
(In reply to comment #4)
> Patch still missing in upstream master :-(

Hi,

It will probably take longer to finalize the request for new account with fdo. This is what it takes to be able to `git push' it, right?

If you have an account already, please `push git' yourself on our behalf. Thanks.
S.
Comment 7 Alan Coopersmith 2009-12-10 07:36:23 UTC
To get a fix into Xorg server master, you need to mail it to xorg-devel and
have it reviewed, then ask the release manager for the next Xorg server 
release to include it - individual developers no longer push to git master
directly.

See the new development process summary on: http://www.x.org/wiki/XServer
Comment 8 David Heidelberg (okias) 2009-12-10 08:00:19 UTC
Great, what about commit patch? It 100% work and solve two problems...
Comment 9 Sebastian Glita 2009-12-10 09:01:06 UTC
hey, found this by chance:

http://lists.x.org/archives/xorg-devel/2009-December/003908.html


*** This bug has been marked as a duplicate of bug 25374 ***


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.