Bug 25567 - commit "drm/radeon/kms/r600/r700: fallback gracefully on ucode failure" introduces screen corruption
Summary: commit "drm/radeon/kms/r600/r700: fallback gracefully on ucode failure" intro...
Status: RESOLVED FIXED
Alias: None
Product: Mesa
Classification: Unclassified
Component: Drivers/DRI/R600 (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Default DRI bug account
QA Contact:
URL:
Whiteboard:
Keywords:
: 25580 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-10 13:04 UTC by Florian Scandella
Modified: 2009-12-16 04:47 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments
dmesg working (49.75 KB, text/plain)
2009-12-10 14:02 UTC, Florian Scandella
Details
xorg.0.log working (34.69 KB, text/plain)
2009-12-10 14:03 UTC, Florian Scandella
Details
dmesg with corruption (48.85 KB, text/plain)
2009-12-10 14:21 UTC, Florian Scandella
Details
xorg.0.log with corruption (34.74 KB, text/plain)
2009-12-10 14:21 UTC, Florian Scandella
Details
possible fix (2.11 KB, patch)
2009-12-15 14:31 UTC, Alex Deucher
Details | Splinter Review

Description Florian Scandella 2009-12-10 13:04:52 UTC
observed on rv770, mesa+librm+ddx git, linux 2.6.32.y+drm-radeon-testing

massive screen corruptions, mostly fonts are garbage.

reverting the commit (779720a3209849be202ac36a811e934865c50971) fixes the problem (already reported on irc)
Comment 1 Alex Deucher 2009-12-10 13:50:55 UTC
please include your dmesg and xorg log in the working and non-working cases.
Comment 2 Florian Scandella 2009-12-10 14:02:05 UTC
Created attachment 31949 [details]
dmesg working
Comment 3 Florian Scandella 2009-12-10 14:03:26 UTC
Created attachment 31950 [details]
xorg.0.log working

for non working case i have to recompile the kernel first .. but as far as i could see, there was no difference
Comment 4 Florian Scandella 2009-12-10 14:21:18 UTC
Created attachment 31951 [details]
dmesg with corruption
Comment 5 Florian Scandella 2009-12-10 14:21:47 UTC
Created attachment 31952 [details]
xorg.0.log with corruption
Comment 6 Rafał Miłecki 2009-12-12 11:49:02 UTC
Cross-linking. Other problem caused by this commit: bug #25567 . Thanks for noticing.
Comment 7 Alex Deucher 2009-12-15 14:22:39 UTC
*** Bug 25580 has been marked as a duplicate of this bug. ***
Comment 8 Alex Deucher 2009-12-15 14:31:39 UTC
Created attachment 32097 [details] [review]
possible fix

I don't really see how 779720a3209849be202ac36a811e934865c50971 can cause corruption or hangs as it just moves the reading of the ucode from file slightly later in the process, however the ucode isn't used until much later.  I suspect the earlier ucode loading is introducing a delay that's masking the real issue.  This patch may fix the actual issue hopefully.
Comment 9 Rafał Miłecki 2009-12-15 14:43:48 UTC
(In reply to comment #8)
> Created an attachment (id=32097) [details]
> possible fix
> 
> I don't really see how 779720a3209849be202ac36a811e934865c50971 can cause
> corruption or hangs as it just moves the reading of the ucode from file
> slightly later in the process, however the ucode isn't used until much later. 
> I suspect the earlier ucode loading is introducing a delay that's masking the
> real issue.  This patch may fix the actual issue hopefully.

Works great :) Fixed locking up and some single pixels corruptions I noticed after switching to VT1.

Tried booting 3 times so I'm quite sure it's working :)
Comment 10 Florian Scandella 2009-12-16 04:43:58 UTC
thx, this fixed my issues.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.