This soon-to-be attached patch converts the K&R-style prototypes in Xserver/dix to the newer ANSI-style. The conversion was done by hand in an effort to preserve the comments which annotate variables. These have been moved into doxygen(esque?) "stubs" above each function. Effort was taken to preserve the local "style" of different files. As expected, the diff is quite large, but fairly obvious. I've checked over the patch by hand and found no type discrepancies. The resulting server runs as expected in my near-default configuration. Depending on the reception of such large a large, intrusive patch, I'll move on to ANSI-fying other areas in Xorg CVS in the coming weeks.
Created attachment 1919 [details] [review] Patch to ANSI-fy programs/Xserver/dix
Created attachment 1945 [details] [review] ANSI-fy Xserver/dix; update Doxygen stubs to conforming syntax This update changes the \arg to the more universal and fitting Doxygen \param. I also checked over the argument lists for types that would be subject to promotion in K&R vs ANSI, nothing relevant (as far as my understanding of K&R goes) was found.
Taking bug for commit...
Created attachment 2037 [details] [review] Patch for 2005-03-07-trunk (same as attachment #1945 [details] [review] + Changelog diff)
Patch checked-in... /cvs/xorg/xc/ChangeLog,v <-- xc/ChangeLog new revision: 1.802; previous revision: 1.801 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. /cvs/xorg/xc/programs/Xserver/dix/atom.c,v <-- xc/programs/Xserver/dix/atom.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/colormap.c,v <-- xc/programs/Xserver/dix/colormap.c new revision: 1.6; previous revision: 1.5 /cvs/xorg/xc/programs/Xserver/dix/cursor.c,v <-- xc/programs/Xserver/dix/cursor.c new revision: 1.4; previous revision: 1.3 /cvs/xorg/xc/programs/Xserver/dix/devices.c,v <-- xc/programs/Xserver/dix/devices.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/dispatch.c,v <-- xc/programs/Xserver/dix/dispatch.c new revision: 1.7; previous revision: 1.6 /cvs/xorg/xc/programs/Xserver/dix/dixfonts.c,v <-- xc/programs/Xserver/dix/dixfonts.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/dixutils.c,v <-- xc/programs/Xserver/dix/dixutils.c new revision: 1.6; previous revision: 1.5 /cvs/xorg/xc/programs/Xserver/dix/events.c,v <-- xc/programs/Xserver/dix/events.c new revision: 1.7; previous revision: 1.6 /cvs/xorg/xc/programs/Xserver/dix/extension.c,v <-- xc/programs/Xserver/dix/extension.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/gc.c,v <-- xc/programs/Xserver/dix/gc.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/glyphcurs.c,v <-- xc/programs/Xserver/dix/glyphcurs.c new revision: 1.2; previous revision: 1.1 /cvs/xorg/xc/programs/Xserver/dix/grabs.c,v <-- xc/programs/Xserver/dix/grabs.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/main.c,v <-- xc/programs/Xserver/dix/main.c new revision: 1.5; previous revision: 1.4 /cvs/xorg/xc/programs/Xserver/dix/pixmap.c,v <-- xc/programs/Xserver/dix/pixmap.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/privates.c,v <-- xc/programs/Xserver/dix/privates.c new revision: 1.4; previous revision: 1.3 /cvs/xorg/xc/programs/Xserver/dix/property.c,v <-- xc/programs/Xserver/dix/property.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/resource.c,v <-- xc/programs/Xserver/dix/resource.c new revision: 1.4; previous revision: 1.3 /cvs/xorg/xc/programs/Xserver/dix/swaprep.c,v <-- xc/programs/Xserver/dix/swaprep.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/swapreq.c,v <-- xc/programs/Xserver/dix/swapreq.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/Xserver/dix/window.c,v <-- xc/programs/Xserver/dix/window.c new revision: 1.7; previous revision: 1.6 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... ... marking bug as FIXED.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.