This patch converts twm to use ANSI-style prototypes. Unfortunately, I cannot coax GCC into warning me about K&R-style declarations, so it is possible that one or two slipped through. twm's code is very well documented; I moved the documentation into Doxygen blocks with proper \param descriptions, etc when available. I have not attached the Doxyfile I'm using as it'd be twm specific, and I'd like to create a shared one for all of the xapps in the future.
Created attachment 1927 [details] [review] ANSIfy and Doxygenate TWM
Taking bug for commit...
Created attachment 2083 [details] [review] Patch for 2005-03-11-trunk (same as attachment #1927 [details] [review] + Changelog diff)
Patch checked-in... /cvs/xorg/xc/ChangeLog,v <-- xc/ChangeLog new revision: 1.808; previous revision: 1.807 /cvs/xorg/xc/programs/twm/add_window.c,v <-- xc/programs/twm/add_window.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/cursor.c,v <-- xc/programs/twm/cursor.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/events.c,v <-- xc/programs/twm/events.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/gc.c,v <-- xc/programs/twm/gc.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/gram.y,v <-- xc/programs/twm/gram.y new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/iconmgr.c,v <-- xc/programs/twm/iconmgr.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/icons.c,v <-- xc/programs/twm/icons.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/list.c,v <-- xc/programs/twm/list.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/menus.c,v <-- xc/programs/twm/menus.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/parse.c,v <-- xc/programs/twm/parse.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/resize.c,v <-- xc/programs/twm/resize.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/twm.c,v <-- xc/programs/twm/twm.c new revision: 1.3; previous revision: 1.2 /cvs/xorg/xc/programs/twm/util.c,v <-- xc/programs/twm/util.c new revision: 1.3; previous revision: 1.2 cvs commit: Using deprecated info format strings. Convert your scripts to use the new argument format and remove '1's from your info file format strings. Mailing the commit message to xorg-commit@lists.freedesktop.org... ... marking bug as FIXED.
Mike Owens: Do you have more of such patches which I can review and commit (it's nice to have someone who cares about code cleanup... :) ?
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.