Bug 25773 - Improve granularity of errors
Summary: Improve granularity of errors
Status: NEW
Alias: None
Product: libatasmart
Classification: Unclassified
Component: library (show other bugs)
Version: unspecified
Hardware: Other All
: medium enhancement
Assignee: Lennart Poettering
QA Contact: Lennart Poettering
Depends on:
Reported: 2009-12-23 01:23 UTC by Jean-Louis
Modified: 2009-12-23 01:23 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Proposed patch for improving granularity of errors (7.07 KB, patch)
2009-12-23 01:23 UTC, Jean-Louis
Details | Splinter Review

Description Jean-Louis 2009-12-23 01:23:06 UTC
Created attachment 32259 [details] [review]
Proposed patch for improving granularity of errors

In function verify_sectors, is raised a->warn also for only 1 reallocated sector... this is a good thing, but for example in Palinsest this is showed with red alarm and for warning generated from raw value I think is excessive.

For have more granular visual alarm:

RED color -> assessment: FAILED (comparing the threshold, failed now)
ORANGE color -> assessment: WARNING (comparing the threshold, failed in past)
YELLOW color -> assessment: CAUTION (without comparing the threshold)
GREEN color -> assessment: GOOD

is needed a little enhancement, for distinguish alarm raised by worst and current value and alarm raised by raw value

I would add a proposed patch for this

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.